935361 - Use CheckPermission in the PContentParent Geolocation message handlers

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Reuben Morais [:reuben]]

Attachment: Use CheckPermission

AssertAppPermission doesn't know how to handle permission requests coming from tabs in the browser app. mozilla::CheckPermission is a reusable and more correct version of the workaround being used in RecvAddGeolocationListener right now.

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 827804 [details] [diff] [review]
Use CheckPermission

Review of attachment 827804 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/ContentParent.cpp
@@ -3049,5 @@
> -      if (appId == principalAppId) {
> -        found = true;
> -        break;
> -      }
> -    }

Why don't we need this block of code anymore?


I am looking at:
   http://mxr.mozilla.org/mozilla-central/source/dom/ipc/AppProcessChecker.cpp#197

Comment 2

[Reuben Morais [:reuben]]

(In reply to Doug Turner (:dougt) from comment #1)
> ::: dom/ipc/ContentParent.cpp
> @@ -3049,5 @@
> > -      if (appId == principalAppId) {
> > -        found = true;
> > -        break;
> > -      }
> > -    }
> 
> Why don't we need this block of code anymore?

We do, see AssertAppPrincipal in the same file. CheckPermission calls it before doing anything else.

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b57eb03f0abe