935370 - Inline all Pod functions

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: inline-pod-functions.patch

Is there a reason why some of the Pod template functions are `MOZ_ALWAYS_INLINE static` and others are just `static`? These functions were all `JS_ALWAYS_INLINE static` in jsutils.h.

Comment 1

[Jeff Walden [:Waldo]]

Comment on attachment 827813 [details] [diff] [review]
inline-pod-functions.patch

Review of attachment 827813 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure why it's this way, offhand.  As a nitpick, I'd prefer the order be |static MOZ_ALWAYS_INLINE| rather than the reverse.  (And I'd rather see inline than MOZ_ALWAYS_INLINE, as the latter suggests we've really inspected uses and know that inline is *always* what we want, but that's not necessarily the case for all of these.)

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #1)
> As a nitpick, I'd prefer the order be |static MOZ_ALWAYS_INLINE| rather than the reverse.

I agree; I was just following the style of the other template functions in PodOperations.h.

Comment 3

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/23aa24fa8d20

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/23aa24fa8d20

Comment 5

[Chris Peterson [:cpeterson]]

Comment on attachment 827813 [details] [diff] [review]
inline-pod-functions.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 856850 (Firefox 23)
User impact if declined: Negligible code size difference.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Very low risk. These functions used to be inline, but some of the `inline` keywords were not copied when these functions were moved from the jsutils.h header file to PodOperations.h.
String or IDL/UUID changes made by this patch: N/A

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/680778a8bcb3