935392 - RTL support for home pager in large/xlarge layouts

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Lauren]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.101 Safari/537.36

Steps to reproduce:

this bug blocks 702845; RTL support for the home pager - it should align to the left in RTL locale

Comment 1

[Lauren]

Attachment: homepager_rtl.patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 827856 [details] [diff] [review]
homepager_rtl.patch

Throwing review to Lucas while Sriram is on PTO

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I think the APK linked to in bug 702845 has this patch in it, if you want to see it in action.

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 827856 [details] [diff] [review]
homepager_rtl.patch

Review of attachment 827856 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/resources/layout-large-v11/home_pager.xml
@@ +17,5 @@
>      <org.mozilla.gecko.home.TabMenuStrip android:layout_width="fill_parent"
>                                           android:layout_height="32dip"
>                                           android:background="@color/background_light"
>                                           android:layout_gravity="top"
> +                                         android:layoutDirection="ltr"

This attribute is only available on Android 19, right? What exactly is layoutDirection achieving here?

Comment 5

[Lauren]

Attachment: homepager

It is available in API 17, as indicated here: http://developer.android.com/reference/android/R.attr.html#layoutDirection

This image shows what the homepager looks like in RTL locale without the layoutDirection specified. Probably not the most elegant solution - open to suggestions.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.