RTL support for home pager in large/xlarge layouts

ASSIGNED
Assigned to

Status

()

Firefox for Android
General
P3
normal
ASSIGNED
4 years ago
9 months ago

People

(Reporter: Lauren, Assigned: Lauren)

Tracking

(Blocks: 1 bug)

27 Branch
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.101 Safari/537.36

Steps to reproduce:

this bug blocks 702845; RTL support for the home pager - it should align to the left in RTL locale
(Assignee)

Updated

4 years ago
Blocks: 702845
Depends on: 924418
OS: Mac OS X → Android
Hardware: x86 → ARM
(Assignee)

Comment 1

4 years ago
Created attachment 827856 [details] [diff] [review]
homepager_rtl.patch
Attachment #827856 - Flags: feedback?

Updated

4 years ago
Assignee: nobody → kolauren
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Updated

4 years ago
Attachment #827856 - Flags: feedback? → review?(sriram)
Comment on attachment 827856 [details] [diff] [review]
homepager_rtl.patch

Throwing review to Lucas while Sriram is on PTO
Attachment #827856 - Flags: review?(sriram) → review?(lucasr.at.mozilla)
I think the APK linked to in bug 702845 has this patch in it, if you want to see it in action.
Comment on attachment 827856 [details] [diff] [review]
homepager_rtl.patch

Review of attachment 827856 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/resources/layout-large-v11/home_pager.xml
@@ +17,5 @@
>      <org.mozilla.gecko.home.TabMenuStrip android:layout_width="fill_parent"
>                                           android:layout_height="32dip"
>                                           android:background="@color/background_light"
>                                           android:layout_gravity="top"
> +                                         android:layoutDirection="ltr"

This attribute is only available on Android 19, right? What exactly is layoutDirection achieving here?
Attachment #827856 - Flags: review?(lucasr.at.mozilla)
(Assignee)

Comment 5

4 years ago
Created attachment 8342870 [details]
homepager

It is available in API 17, as indicated here: http://developer.android.com/reference/android/R.attr.html#layoutDirection

This image shows what the homepager looks like in RTL locale without the layoutDirection specified. Probably not the most elegant solution - open to suggestions.
No longer depends on: 924418
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.