935413 - WARNING: The SQL statement 'UPDATE moz_startups SET startups = :startup_count last_startup = :startup_time; ' could not be compiled due to an error: near "last_startup": syntax error: file .../mozilla/storage/src/moz

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect)

Description

[ISHIKAWA, Chiaki]

With the DEBUG BUILD of TB from recent comm-central source, I see the following 
error when I start up the binary for the first time after compilation.
Note the "could not be compiled line".

--DOMWINDOW == 27 (0xc0ca220) [serial = 17] [outer = 0xaf89260] [url = about:blank]
--DOMWINDOW == 26 (0xbd40158) [serial = 15] [outer = 0xb57fa10] [url = about:blank]
--DOMWINDOW == 25 (0xbda5668) [serial = 16] [outer = 0xb5727b0] [url = about:blank]
--DOCSHELL 0xc58dc80 == 11 [id = 12]
WARNING: Could not get disk status from nsIDiskSpaceWatcher: file /new-hd1/extra/ishikawa/TB-3HG/NEW-COMMSRC/mozilla/uriloader/prefetch/nsOfflineCacheUpdateService.cpp, line 312
WARNING: The SQL statement 'UPDATE moz_startups SET startups = :startup_count last_startup = :startup_time;
' could not be compiled due to an error: near "last_startup": syntax error: file /new-hd1/extra/ishikawa/TB-3HG/NEW-COMMSRC/mozilla/storage/src/mozStorageConnection.cpp, line 991
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /new-hd1/extra/ishikawa/TB-3HG/NEW-COMMSRC/mozilla/storage/src/mozStorageConnection.cpp, line 1329
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /new-hd1/extra/ishikawa/TB-3HG/NEW-COMMSRC/mozilla/netwerk/base/src/Seer.cpp, line 531
++DOCSHELL 0xc58dc80 == 12 [id = 13]
++DOMWINDOW == 26 (0xbdb55e8) [serial = 30] [outer = (nil)]
++DOMWINDOW == 27 (0xb2bfa70) [serial = 31] [outer = 0xbdb55e8]
WAR

I have not seen this error before, and I have no idea what it means.
Well I could tell that SQL command interpreter is complaining about
syntax error but I have no idea why this happens out of blue.
And I don't know the impact of it yet. (I am yet to run |make mozmill| test suite run.

I am just raising a flag for someone to investigate here.

TIA

Comment 1

[Marco Bonardo [:mak]]

That query is indeed wrong, it has been introduced by bug 881804

Comment 2

[ISHIKAWA, Chiaki]

Thank you for the update. It was not clear that it was related to Networking:HTTP from the error I saw. 

TIA

Comment 3

[ISHIKAWA, Chiaki]

(In reply to Marco Bonardo [:mak] from comment #1)
> That query is indeed wrong, it has been introduced by bug 881804

I have found out running TB's test suite |make mozmill| finishes and didn't complain about test failures 
due to the syntax error.

This means that
 - test items in |make mozmill| are not affected by this syntax error, and
 - the feature that uses this SQL is not tested on its own at all by TB's |make mozmill| test suite.

I am not sure if we should expect TB to test this feature thoroughly if this feature is
HTTP-related, but FF test suite should IMHO.

Strange that TB invokes HTTP function, but maybe it was accessing the greeting image that is shown
in the message pane when we first open TB.
(And |make mozmill| seems to be run in such a way not to show this greeting page.)

TIA

Comment 4

[u408661]

Attachment: stupid_comma.patch

/me facepalms

Comment 5

[u408661]

Try is happy: https://tbpl.mozilla.org/?tree=Try&rev=dfa622d988b1

Comment 6

[u408661]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c09f393de794

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c09f393de794

Comment 8

[u408661]

Comment on attachment 830339 [details] [diff] [review]
stupid_comma.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 881804
User impact if declined: Predictive actions won't work properly in the startup case
Testing completed (on m-c, etc.): on m-c for a few days
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

Comment 9

[u408661]

https://hg.mozilla.org/releases/mozilla-aurora/rev/97f50dda2d9a

Comment 10

[u279076]

Ishikawa, can you please confirm this is fixed for you now in Firefox 27 and 28.

Comment 11

[ISHIKAWA, Chiaki]

(In reply to Anthony Hughes, QA Mentor (:ashughes) [unavailable until Jan 2, 2014] from comment #10)
> Ishikawa, can you please confirm this is fixed for you now in Firefox 27 and
> 28.

Actually, I noticed the error while running TB (thunderbird) from comm-central tree back in October/November time frame. Once the patch was introduced I no longer see the error.
Thank you for the patch.
Sorry, I did not change the flag here myself.

TIA

Comment 12

[u279076]

Marking verified based on comment 11.