935494 - AssertAppPrincipal doesn't compile when MOZ_CHILD_PERMISSIONS is not defined

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: bug.patch

It's just a namespace problem.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 828020 [details] [diff] [review]
bug.patch

>+AssertAppPrincipal(mozilla::dom::PContentParent* aActor,

Why do you need the namespace qualifier there given the "using namespace mozilla::dom" above?

>+CheckPermission(mozilla::dom::PContentParent* aActor,

Likewise.

r=me with that explained or fixed.

Comment 3

[Andrea Marchesini [:baku]]

> Why do you need the namespace qualifier there given the "using namespace
> mozilla::dom" above?

because that "using namespace mozilla::dom is inside #ifdef MOZ_CHILD_PERMISSIONS:

https://mxr.mozilla.org/mozilla-central/source/dom/ipc/AppProcessChecker.cpp#10

Comment 4

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/98bf1daa9e90

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/98bf1daa9e90