935523 - Remove setShadowVisibility() from toolbar

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

Not needed anymore, not even in the overscroll bits.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Remove setShadowVisibility() as it's not needed anymore (r=sriram)

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Make BrowserApp's mBrowserToolbar non-static and private (r=sriram)

Comment 3

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 828050 [details] [diff] [review]
Remove setShadowVisibility() as it's not needed anymore (r=sriram)

Review of attachment 828050 [details] [diff] [review]:
-----------------------------------------------------------------

Finally! Yaaaay!

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 828051 [details] [diff] [review]
Make BrowserApp's mBrowserToolbar non-static and private (r=sriram)

Review of attachment 828051 [details] [diff] [review]:
-----------------------------------------------------------------

This is the best patch ever I've been waiting for. The day I saw this, I was shocked. With a DEX file in the addon, an addon can easy get hold of mBrowserToolbar, and there by any activity and can do anything with it! :O

Comment 5

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/e18759fb71ea
https://hg.mozilla.org/integration/fx-team/rev/9a56cb111bf5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e18759fb71ea
https://hg.mozilla.org/mozilla-central/rev/9a56cb111bf5