935530 - Fix subtle misalignment of stop button

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

Turns out the icon itself is slightly misaligned. We should probably uplift this to aurora/beta.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Fix subtle misalignment of stop button (r=sriram)

Comment 2

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/ff7e84f5968b

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 828059 [details] [diff] [review]
Fix subtle misalignment of stop button (r=sriram)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Not sure when we regressed. Fx25 and later are definitely affected.
User impact if declined: Slightly misaligned stop button in toolbar (which is core piece of our UI). Make us look like amateurs.
Testing completed (on m-c, etc.): Local tests, pushed to m-c now. 
Risk to taking this patch (and alternatives if risky): Very low. This is just fixing the stop icon images. No code changes.
String or IDL/UUID changes made by this patch: n/a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ff7e84f5968b

Comment 5

[bhavana bajaj [:bajaj]]

Comment on attachment 828059 [details] [diff] [review]
Fix subtle misalignment of stop button (r=sriram)

low risk, polish only. Approving on aurora/beta

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fba31896973c
https://hg.mozilla.org/releases/mozilla-beta/rev/b520ea3df238

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/b520ea3df238