Closed
Bug 935530
Opened 12 years ago
Closed 12 years ago
Fix subtle misalignment of stop button
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox26 verified, firefox27 verified, firefox28 verified, b2g-v1.2 fixed)
VERIFIED
FIXED
Firefox 28
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(1 file)
|
4.13 KB,
patch
|
sriram
:
review+
bajaj
:
approval-mozilla-aurora+
bajaj
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Turns out the icon itself is slightly misaligned. We should probably uplift this to aurora/beta.
| Assignee | ||
Comment 1•12 years ago
|
||
| Assignee | ||
Updated•12 years ago
|
Attachment #828059 -
Flags: review?(sriram)
Updated•12 years ago
|
Attachment #828059 -
Flags: review?(sriram) → review+
| Assignee | ||
Comment 2•12 years ago
|
||
| Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 828059 [details] [diff] [review]
Fix subtle misalignment of stop button (r=sriram)
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Not sure when we regressed. Fx25 and later are definitely affected.
User impact if declined: Slightly misaligned stop button in toolbar (which is core piece of our UI). Make us look like amateurs.
Testing completed (on m-c, etc.): Local tests, pushed to m-c now.
Risk to taking this patch (and alternatives if risky): Very low. This is just fixing the stop icon images. No code changes.
String or IDL/UUID changes made by this patch: n/a
Attachment #828059 -
Flags: approval-mozilla-beta?
Attachment #828059 -
Flags: approval-mozilla-aurora?
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Comment 5•12 years ago
|
||
Comment on attachment 828059 [details] [diff] [review]
Fix subtle misalignment of stop button (r=sriram)
low risk, polish only. Approving on aurora/beta
Attachment #828059 -
Flags: approval-mozilla-beta?
Attachment #828059 -
Flags: approval-mozilla-beta+
Attachment #828059 -
Flags: approval-mozilla-aurora?
Attachment #828059 -
Flags: approval-mozilla-aurora+
Comment 6•12 years ago
|
||
Comment 7•12 years ago
|
||
Updated•12 years ago
|
status-b2g-v1.2:
--- → fixed
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•