935568 - update branches that use 4.10 RTM to 4.10.2 RTM

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kai Engert [:KaiE:]]

Mozilla 27, currently aurora, uses NSPR 4.10.2 beta.

We must update it to NSPR 4.10.2 RTM (not released yet).

This should ideally happen prior to the next branch merge on Dec 9.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: update to beta2

We should begin by updating to the beta2 snapshot for testing of the recent changes.

Comment 2

[Wan-Teh Chang]

Comment on attachment 828093 [details] [diff] [review]
update to beta2

Review of attachment 828093 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc.

IMPORTANT: I may change or remove the new PR_SocketPollingHandle and
PR_SocketPollingStatus functions added in bug 888581 before the
NSPR 4.10.2 final release. So we should not push NSPR_4_10_2_BETA2
to an hg repository other than mozilla-inbound and mozilla-central.

Another option is to create the NSPR 4.10.2 final release without
these two changesets:
https://hg.mozilla.org/projects/nspr/rev/1bd2f00745d3
https://hg.mozilla.org/projects/nspr/rev/77c4ee30c1fe

Comment 3

[Kai Engert [:KaiE:]]

Attachment: update to NSPR 4.10.2 RTM (this patch works for m-c28 and m-a27 which currently use beta1)

I've created the NSPR 4.10.2 RTM as requested by Wan-Teh.

Comment 4

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/31d1b55d9c9b

Comment 5

[Kai Engert [:KaiE:]]

Comment on attachment 829710 [details] [diff] [review]
update to NSPR 4.10.2 RTM (this patch works for m-c28 and m-a27 which currently use beta1)

Approval justification: Aurora must use a RTM version of NSPR, not a beta.

Comment 6

[Kai Engert [:KaiE:]]

Attachment: update branches that use 4.10.1 RTM to 4.10.2 RTM - 26 (and 25?)

It's up to dveditz if he wants this update. Patch applies to m-b 26 and m-r 25 branches.

changes: 915522, 888546, 770534, 927687

Comment 7

[Kai Engert [:KaiE:]]

Attachment: update branches that use 4.10 RTM to 4.10.2 RTM - esr24

It's up to dveditz if he wants this update. Patch applies to esr24 branch.

changes: 915522, 888546, 770534, 927687, 888273, 907512

Comment 8

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Please update configure.in to require the new version of NSPR too. It seems like some of the bug fixes in the new release are important even if there is no ABI issue.

Comment 9

[Kai Engert [:KaiE:]]

(In reply to Brian Smith from comment #8)
> Please update configure.in to require the new version of NSPR too.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0e8bbe5e71d

Comment 10

[Kai Engert [:KaiE:]]

Attachment: update to NSPR 4.10.2 RTM (this patch v2 works for m-c28 and m-a27 which currently use beta1)

Comment 11

[Kai Engert [:KaiE:]]

Attachment: update branches that use 4.10.1 RTM to 4.10.2 RTM - beta-26 and release-25 - (patch v2 including configure.in update)

Comment 12

[Kai Engert [:KaiE:]]

Attachment: update branches that use 4.10 RTM to 4.10.2 RTM - esr24 - (patch v2 including configure.in update)

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/31d1b55d9c9b
https://hg.mozilla.org/mozilla-central/rev/c0e8bbe5e71d

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Adjusting the summary and the flags to show that this can be uplifted as high at FF25 (leaving the approval request for consideration in the dot release).

Comment 15

[Kai Engert [:KaiE:]]

(In reply to [e-mail] [:lsblakk] from comment #14)
> Adjusting the summary and the flags to show that this can be uplifted as
> high at FF25

As high as ESR24 even - that's the only one using the oldest NSPR 4.10 that you used in the summary.

Comment 16

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1368e2ac4c57

Comment 17

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/mozilla-beta/rev/73428a0ad312

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/73428a0ad312

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/9fa84d1d4a61
https://hg.mozilla.org/releases/mozilla-esr24/rev/bc45c98c5539

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Also pushed to GECKO2410esr_2013102201_RELBRANCH.
https://hg.mozilla.org/releases/mozilla-esr24/rev/7d89d35ff7e3

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Attachment: update b2g18 branch to 4.10.2 RTM

Well, that was remarkably painless. Almost *too* painless... :P

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: Unfixed security bugs (like bug 927687)
Testing completed: This version of NSPR is used on all other branches without issue. On Try, this patch successfully built all supported platforms and passes tests on the B2G ICS emulator.
Risk to taking this patch (and alternatives if risky): Per wtc, NSPR updates are generally low-risk and uneventful. The fact that no other branches have had issues with this version would seem to corroborate that.
String or UUID changes made by this patch: None

Comment 22

[Wan-Teh Chang]

Comment on attachment 8367779 [details] [diff] [review]
update b2g18 branch to 4.10.2 RTM

Review of attachment 8367779 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc. Please also modify nsprpub/config/prdepend.h. Just remove
the blank line at the end of that file.

Comment 23

[Preeti Raghunath(:Preeti)]

Comment on attachment 8367779 [details] [diff] [review]
update b2g18 branch to 4.10.2 RTM

Not aware of security issues at this time. Please re-nom once security threat is known.

Comment 24

[Preeti Raghunath(:Preeti)]

Comment on attachment 8367779 [details] [diff] [review]
update b2g18 branch to 4.10.2 RTM

As explained 935568 *is* the security update for bug 927687

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/c5dcca9aeff8
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/c5dcca9aeff8