Closed Bug 935624 Opened 6 years ago Closed 6 years ago

APZCs don't update FrameMetrics correctly when a layers update comes in

Categories

(Core :: Panning and Zooming, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(2 files)

Something that is more obvious now but was probably always an issue, is that in NotifyLayersUpdate various fields in mFrameMetrics are not updated. This used to be ok in the single-APZC case because for the most part these fields wouldn't change but now that we have nested APZCs, the parent APZC might set a resolution which causes the values of the child APZC to change, and the child needs to pick up these updates.
Attachment #828140 - Flags: review?(botond)
Attachment #828140 - Flags: review?(botond) → review+
Comment on attachment 828141 [details] [diff] [review]
Part 2 - Update various FrameMetrics things in NotifyLayersUpdate

Review of attachment 828141 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/FrameMetrics.h
@@ +142,5 @@
>    // instead.
>    //
>    // This value is valid for nested scrollable layers as well, and is still
> +  // relative to the layer tree origin. This value is provided by Gecko at
> +  // layout/paint time.

"provided at layout/paint time"
Attachment #828141 - Flags: review?(botond) → review+
(In reply to Botond Ballo [:botond] from comment #2)
> Comment on attachment 828141 [details] [diff] [review]
> Part 2 - Update various FrameMetrics things in NotifyLayersUpdate
> 
> Review of attachment 828141 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/layers/FrameMetrics.h
> @@ +142,5 @@
> >    // instead.
> >    //
> >    // This value is valid for nested scrollable layers as well, and is still
> > +  // relative to the layer tree origin. This value is provided by Gecko at
> > +  // layout/paint time.
> 
> "provided at layout/paint time"

Sorry, ignore that. The comment is fine.
https://hg.mozilla.org/mozilla-central/rev/5040cffe32af
https://hg.mozilla.org/mozilla-central/rev/700ce8c0d14d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.