935624 - APZCs don't update FrameMetrics correctly when a layers update comes in

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Stop meddling with the resolution fields in APZC

Something that is more obvious now but was probably always an issue, is that in NotifyLayersUpdate various fields in mFrameMetrics are not updated. This used to be ok in the single-APZC case because for the most part these fields wouldn't change but now that we have nested APZCs, the parent APZC might set a resolution which causes the values of the child APZC to change, and the child needs to pick up these updates.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Update various FrameMetrics things in NotifyLayersUpdate

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 828141 [details] [diff] [review]
Part 2 - Update various FrameMetrics things in NotifyLayersUpdate

Review of attachment 828141 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/FrameMetrics.h
@@ +142,5 @@
>    // instead.
>    //
>    // This value is valid for nested scrollable layers as well, and is still
> +  // relative to the layer tree origin. This value is provided by Gecko at
> +  // layout/paint time.

"provided at layout/paint time"

Comment 3

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #2)
> Comment on attachment 828141 [details] [diff] [review]
> Part 2 - Update various FrameMetrics things in NotifyLayersUpdate
> 
> Review of attachment 828141 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/layers/FrameMetrics.h
> @@ +142,5 @@
> >    // instead.
> >    //
> >    // This value is valid for nested scrollable layers as well, and is still
> > +  // relative to the layer tree origin. This value is provided by Gecko at
> > +  // layout/paint time.
> 
> "provided at layout/paint time"

Sorry, ignore that. The comment is fine.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5040cffe32af
https://hg.mozilla.org/integration/mozilla-inbound/rev/700ce8c0d14d

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5040cffe32af
https://hg.mozilla.org/mozilla-central/rev/700ce8c0d14d