935636 - [contacts][matcher] address in existing contact duplicated if importing same vCard/.vcf file several times

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Boot2Gecko 1.2.0.0-prerelease 20131104224010 on Keon, update channel 'default'

When importing contacts from a .vcf file (vcard 2.1 from Android) several times, the addresses of the contacts get duplicated.

Comment 1

[Michał Budzyński (:michalbe)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19164

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8421036 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19164

This looks good to me, but can you add a test case that tries to perform a duplicate merge?  Thanks!

Comment 3

[Michał Budzyński (:michalbe)]

Jose Manuel, why did you assign yourself to my bug? Are you writing tests for me :)?

Comment 4

[Jose Manuel Cantera]

(In reply to Michał Budzyński (:michalbe) from comment #3)
> Jose Manuel, why did you assign yourself to my bug? Are you writing tests
> for me :)?

I thought you were not actively working on this one. Please let me know an ETA or We will steal it. Ah, and please ask me for a review once it is finished

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

I'm including this bug in the current sprint.

@michalbe, could you update with an estimation?

Comment 6

[Michał Budzyński (:michalbe)]

Somehow this patch doesn't solve the problem anymore, I'm investigating it now.

Comment 7

[Michał Budzyński (:michalbe)]

Oh, so the problem is that when we create new contact using Add contact (not when we import it), then export it to the card and import again, the addresses will duplicate. When we import the contact we don't have from a vcard and then import it again everything works as expected. So this patch solves the issue partially. Working on the first condition now.

Comment 8

[Michał Budzyński (:michalbe)]

Ok, so somehow when importing a contacts from vcard our importer creates an empty 'region' field in the address object, I'm working on smarter way of checking if objects are equal.

Comment 9

[Michał Budzyński (:michalbe)]

Attachment: Patch

Comment 10

[Jose Manuel Cantera]

Comment on attachment 8437737 [details] [review]
Patch

thanks Michal

Comment 11

[Michał Budzyński (:michalbe)]

Thank you Jose Manuel!

Landed: https://github.com/mozilla-b2g/gaia/commit/c0709e95fa79e35913e3e6788e80cd874d29990e