Closed Bug 935641 Opened 10 years ago Closed 10 years ago

Don't copy surfaces in DeprecatedTextureHostBasic::Lock()

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(1 file)

On a microbenchmark I'm using, BasicCompositor is about 100X slower than main-thread BasicLayers right now. Matt Woodrow pinpointed the problem to DeprecatedTextureHostBasic::Lock(), which accidentally duplicates the surface. With this patch it's much closer to main thread performance (about 2-5X, and much closer with bug 882447).
Attachment #828169 - Flags: review?(matt.woodrow)
Attachment #828169 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/40b2d934b46d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.