Tidy up XPCStringConvert::ReadableToJSVal

RESOLVED FIXED in mozilla28

Status

()

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

unspecified
mozilla28
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Assignee

Description

6 years ago
Posted patch stringSplinter Review
Follow up to Bug 934544.
Attachment #828226 - Flags: review?(bzbarsky)
Comment on attachment 828226 [details] [diff] [review]
string

>-        if (shared) {
>+        if (shared)

Current local style is generally to brace single-line if bodies.  Please follow it.

>+        if (NS_FAILED(rv))
>+            return rv;

And here.

r=me
Attachment #828226 - Flags: review?(bzbarsky) → review+
Assignee

Comment 2

6 years ago
The prevalent style in XPConnect is actually to have no braces.
https://hg.mozilla.org/mozilla-central/rev/9f77a15c224c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.