Closed Bug 935696 Opened 7 years ago Closed 7 years ago

Tidy up XPCStringConvert::ReadableToJSVal

Categories

(Core :: XPConnect, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: evilpie, Assigned: evilpie)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch stringSplinter Review
Follow up to Bug 934544.
Attachment #828226 - Flags: review?(bzbarsky)
Comment on attachment 828226 [details] [diff] [review]
string

>-        if (shared) {
>+        if (shared)

Current local style is generally to brace single-line if bodies.  Please follow it.

>+        if (NS_FAILED(rv))
>+            return rv;

And here.

r=me
Attachment #828226 - Flags: review?(bzbarsky) → review+
The prevalent style in XPConnect is actually to have no braces.
https://hg.mozilla.org/mozilla-central/rev/9f77a15c224c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.