Closed
Bug 935696
Opened 11 years ago
Closed 11 years ago
Tidy up XPCStringConvert::ReadableToJSVal
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: evilpies, Assigned: evilpies)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
9.11 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Follow up to Bug 934544.
Attachment #828226 -
Flags: review?(bzbarsky)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 828226 [details] [diff] [review]
string
>- if (shared) {
>+ if (shared)
Current local style is generally to brace single-line if bodies. Please follow it.
>+ if (NS_FAILED(rv))
>+ return rv;
And here.
r=me
Attachment #828226 -
Flags: review?(bzbarsky) → review+
The prevalent style in XPConnect is actually to have no braces.
|
||
Comment 3•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•