935696 - Tidy up XPCStringConvert::ReadableToJSVal

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Tom S [:evilpie]]

Attachment: string

Follow up to Bug 934544.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 828226 [details] [diff] [review]
string

>-        if (shared) {
>+        if (shared)

Current local style is generally to brace single-line if bodies.  Please follow it.

>+        if (NS_FAILED(rv))
>+            return rv;

And here.

r=me

Comment 2

[Tom S [:evilpie]]

The prevalent style in XPConnect is actually to have no braces.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1bc46d4abd0d
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa66c9f42ff4

Comment 4

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f77a15c224c

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9f77a15c224c