935786 - Assertion failure: !IsInnerWindow() || IsCurrentInnerWindow() at nsGlobalWindow.cpp:8909

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Gregor Wagner [:gwagner]]

I am seeing this assertion on mochitests on a debug emulator build.
These tests are currently only enabled on pine and cedar:
https://tbpl.mozilla.org/php/getParsedLog.php?id=30232634&tree=Pine&full=1#error2

It started with this merge: https://hg.mozilla.org/projects/pine/pushloghtml?startID=18&endID=19
Seems like bug 932309 caused it.

Smaug wrote a little debug patch for it. The results should show up here:https://tbpl.mozilla.org/?tree=Pine&showall=1

Comment 1

[Jesse Ruderman]

Does the desktop testcase in bug 937318 help?

Comment 2

[Gregor Wagner [:gwagner]]

Now we have a stack for it:
https://tbpl.mozilla.org/php/getParsedLog.php?id=30446580&tree=Pine&full=1#error1

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: v1

Hopefully people will look at the warning :-(.

Comment 4

[Gregor Wagner [:gwagner]]

I pushed this patch to pine but it turned it orange:
https://tbpl.mozilla.org/?tree=Pine

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: v1.1

With the additional check to keep the old behaviour of allowing an outer in nsAutoWindowStateHelper.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

I went ahead and pushed this to inbound to hopefully clear up bug 934769 while the OOM work continues.

https://hg.mozilla.org/integration/mozilla-inbound/rev/594b69bb0ac3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/594b69bb0ac3