935973 - ThirdPartyCookieProbe errors

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

In bug 837326, John Bacon wrote: « Well I don't care what stats. you gather. I just don't want my error console cluttered up with messages like this:
ThirdPartyCookieProbe: Uncaught error [Exception... "Component returned failure code: 0x804b0051 (NS_ERROR_HOST_IS_IP_ADDRESS) [nsIEffectiveTLDService.getBaseDomainFromHost]"  nsresult: "0x804b0051 (NS_ERROR_HOST_IS_IP_ADDRESS)"  location: "JS frame :: resource://gre/modules/ThirdPartyCookieProbe.jsm :: normalizeHost :: line 181"  data: no]
undefined »

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Note to anyone who picks that bug: this can be fixed by tweaking the |catch| block at http://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/ThirdPartyCookieProbe.jsm?from=ThirdPartyCookieProbe.jsm#l90, as follows:
- check whether the exception is an instance of nsIXPCException;
- if so and, check if its |result| field is equal to Components.results.NS_ERROR_HOST_IS_IP_ADDRESS;
- if so, just swallow the exception and return without doing anything else.

Comment 2

[[:fabrice] Fabrice Desré]

See also bug 902121 and bug 901697

Comment 3

[[:fabrice] Fabrice Desré]

Attachment: cookie-levels.patch

The referrer was '?' in the NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS case.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 829634 [details] [diff] [review]
cookie-levels.patch

Review of attachment 829634 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the following trivial changes

::: toolkit/components/telemetry/ThirdPartyCookieProbe.jsm
@@ +75,5 @@
>          // Not a third-party cookie
>          return;
>        }
>        // Add host to this._thirdPartyCookies
> +      dump("XXX referrer=" + referrer + " 3rdParty=" + docURI.QueryInterface(Ci.nsIURI).spec);

Looks like debugging code.

@@ +99,1 @@
>        // Errors should not remain silent

"Other errors"

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/72f6d31b6317

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/72f6d31b6317