936009 - [Email] Update send email screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Eric Pang [:epang] UX]

Attachment: send-email.png

Pavel, can you help update the sending email screen to use the building blocks?
It should have the text 'Sending email' above the div line and a spinner below

http://buildingfirefoxos.com/building-blocks/progress-and-activity.html

I've attached the current implementation and how it should look after.  Let me know if you have any questions!

Thanks!

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Patch for Gaia/master

Pointer to Github pull-request

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch screenshot

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 829766 [details]
Patch for Gaia/master

Checked this out while investigating if something should be duped to this; code looks fine as does the screenshot.  So stealing review. r=asuth, feel free to land.

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks Andrew :)

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/9649a3cd6d223117b98798c95509fbc95b0645d2

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Are there any plans to port this to 1.2? Bug 931850 is about 1.2 and I likely can make a understandable, shorter version of the string if this fix doesn't get ported.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Archaeopteryx [:aryx] from comment #6)
> Are there any plans to port this to 1.2? Bug 931850 is about 1.2 and I
> likely can make a understandable, shorter version of the string if this fix
> doesn't get ported.

Based on my current understanding of the timeline, 10/28 was the point at which we switched so that you had to be a koi+ blocker to uplift.  Prior to that date, one-off patch approval was allowed.  So you'll want to make the locale-fix.  Feel free to reopen/fix that bug and move it into the appropriate locale-component.