Synchronously neuter large ArrayBuffers in WindowDestroyedEvent::Run

RESOLVED WONTFIX

Status

()

Core
JavaScript Engine
RESOLVED WONTFIX
4 years ago
4 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P2][games])

(Assignee)

Description

4 years ago
When a window goes away, we want to immediately free any large ArrayBuffers it contains, as these may account for a large percentage of all system memory.

I wrote a prototype patch in bug 865959 that does this by iterating over all objects in the window's compartment and freeing all ArrayBuffers.  At a minimum, this could be improved by adding a dirty bit to the compartment that indicates if we have a live large ArrayBuffer in the compartment (increment a count when one is created, decrement when one is destroyed), to avoid paying the cost when we don't have any.  Depending on how long the scan actually takes, it might be worth keeping a list of those buffers, too.

Another problem I noticed is that the actual js_free call for the ArrayBuffer is really slow, on the order of a second for a 1gb buffer, which seems bad.  Maybe there's something bad about the way I'm neutering the array?  Another thing we could do is shove this off to the sweeping thread of something like that, though doing it somewhat asynchronously risks OOMing the browser.

Comment 1

4 years ago
What do you think about maintaining a per-Zone, lazily-created WeakMap of large ArrayBuffers?

The slow js_free is weird... I know doing many frees can be slow (esp. on mac), but I wouldn't think a single js_free would have to do that much work.

Updated

4 years ago
Whiteboard: [MemShrink] → [MemShrink][games]
(Assignee)

Updated

4 years ago
Depends on: 936292
Whiteboard: [MemShrink][games] → [MemShrink:P2][games]
(Assignee)

Comment 2

4 years ago
khuey pointed out that this may not really be okay to do in general, because another content window could have a reference to the ArrayBuffer.  We can probably carve out enough for the asm.js use case.

Comment 3

4 years ago
The resolution of our discussion yesterday was that, if we do bug 936218 and bug 936236, then we won't need to do this.  This avoids the concern in comment 2 and also ensures the release of non-ArrayBuffer resources (WebGL resources, etc).  Given that, does it make sense to resolve this one WONTFIX?
WONTFIXing sounds fine to me.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.