Closed
Bug 936213
Opened 11 years ago
Closed 11 years ago
Dock should not have aria-hidden=true
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g-v1.2 fixed, b2g-v1.3 fixed)
RESOLVED
FIXED
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Keywords: access)
Attachments
(1 file)
|
358 bytes,
text/html
|
crdlc
:
review+
timdream
:
approval-gaia-v1.2+
|
Details |
This is a regression from my patch in bug #930587 (oops!). I changed the page markup to have aria-hidden=true by default. It is also used by the dock, which should always be visible.
|
Assignee | |
Comment 1•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•11 years ago
|
Attachment #828909 -
Flags: review?(crdlc)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 828909 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13490
Thanks a lot
Attachment #828909 -
Flags: review?(crdlc) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Assignee: nobody → eitan
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 828909 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13490
This fixes a regression introduced yesterday in bug #930587.
[Bug caused by] Bug #930587
[User impact] if declined: Screen reader cannot access dock items
[Testing completed]: Yes?
[Risk to taking this patch] (and alternatives if risky): The impact should be minimal.
[String changes made]: None.
Attachment #828909 -
Flags: review?
Attachment #828909 -
Flags: approval-gaia-v1.2?(timdream)
|
||
Updated•11 years ago
|
Attachment #828909 -
Flags: review?
Attachment #828909 -
Flags: approval-gaia-v1.2?(timdream)
Attachment #828909 -
Flags: approval-gaia-v1.2+
|
|
Assignee | |
Comment 5•11 years ago
|
||
I don't know really how to uplift this. Merge tip? Single commit? Am I supposed to leave this for jhford to do?
Flags: needinfo?(jhford)
|
||
Comment 6•11 years ago
|
||
Uplifted 4f06e34dee33d003bb47e625409fae89fc324dfb to:
v1.2: bb50a0a98f950d2e5b475257992eb461aac883b8
status-b2g-v1.2:
--- → fixed
|
|
||
Updated•11 years ago
|
Flags: needinfo?(jhford)
|
|
||
Comment 7•11 years ago
|
||
(In reply to Eitan Isaacson [:eeejay] from comment #5)
> I don't know really how to uplift this. Merge tip? Single commit? Am I
> supposed to leave this for jhford to do?
These will normally be taken care of automagically by me. For the record, we cherry-pick commits onto release branches. Merging tip of master into release branches is not something we ever do.
|
|
||
Comment 8•11 years ago
|
||
Uplifted 4f06e34dee33d003bb47e625409fae89fc324dfb to:
v1.3 already had this commit
status-b2g-v1.3:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•