936223 - mozpoolclient fails to import after install

Status: RESOLVED FIXED

(Testing Graveyard :: Mozpool, defect)

Description

[Justin Wood (:Callek)]

Attachment: [mozpool] v1

So with mozpoolclient 0.1.2 we can't install properly:

    (tmp)[[e-mail]3 tmp]$ pip install mozpoolclient
    Downloading/unpacking mozpoolclient
      Downloading mozpoolclient-0.1.2.tar.gz
      Running setup.py egg_info for package mozpoolclient
     
        package init file 'mozpoolclient/__init__.py' not found (or not a regular file)
    Downloading/unpacking requests>=1.0.0 (from mozpoolclient)
      Downloading requests-2.0.1.tar.gz (412Kb): 412Kb downloaded
      Running setup.py egg_info for package requests
     
    Installing collected packages: mozpoolclient, requests
      Running setup.py install for mozpoolclient
        package init file 'mozpoolclient/__init__.py' not found (or not a regular file)
     
      Running setup.py install for requests
     
    Successfully installed mozpoolclient requests
    Cleaning up...
    (tmp)[[e-mail]3 tmp]$ python
    Python 2.7.3 (default, Apr 10 2013, 09:39:41)
    [GCC 4.4.6 20110731 (Red Hat 4.4.6-3)] on linux2
    Type "help", "copyright", "credits" or "license" for more information.
    >>> import mozpoolclient
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
    ImportError: No module named mozpoolclient
    >>> 

=====

This is due to a missing __init__ in the mozpool folder, and it only works in mozharness due to this silliness: http://mxr.mozilla.org/build/source/mozharness/mozharness/mozilla/testing/mozpool.py#47


I however am taking a slightly different approach since I don't want to do |from mozpool.mozpool import FOO| I am making this a bare py file, until such time as we want to make it a full "package", but this file will still be pip installable.

Comment 1

[Justin Wood (:Callek)]

Comment on attachment 828914 [details] [diff] [review]
[mozpool] v1

Review of attachment 828914 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozpoolclient/setup.py
@@ +6,3 @@
>      author='Zambrano, Armen',
>      author_email='[e-mail]',
> +    py_modules=['mozpoolclient'],

note I did:
mv mozpoolclient/mozpoolclient/mozpoolclient.py mozpoolclient/mozpoolclient.py
rm -rf mozpoolclient/mozpoolclient/

"Splinter" shows it funny here.

Comment 2

[Armen [:armenzg]]

Comment on attachment 828914 [details] [diff] [review]
[mozpool] v1

Review of attachment 828914 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for figuring this out!
Why did you append "a" to the version number? Does that have some implicit meaning?

armenzg@UbuntVM:~/repos/mozpool$ cd mozpoolclient/
armenzg@UbuntVM:~/repos/mozpool/mozpoolclient$ python setup.py sdist
running sdist
running egg_info
creating mozpoolclient.egg-info
writing requirements to mozpoolclient.egg-info/requires.txt
writing mozpoolclient.egg-info/PKG-INFO
writing top-level names to mozpoolclient.egg-info/top_level.txt
writing dependency_links to mozpoolclient.egg-info/dependency_links.txt
writing manifest file 'mozpoolclient.egg-info/SOURCES.txt'
reading manifest file 'mozpoolclient.egg-info/SOURCES.txt'
writing manifest file 'mozpoolclient.egg-info/SOURCES.txt'
running check
creating mozpoolclient-0.1.4a
creating mozpoolclient-0.1.4a/mozpoolclient.egg-info
making hard links in mozpoolclient-0.1.4a...
hard linking README.txt -> mozpoolclient-0.1.4a
hard linking mozpoolclient.py -> mozpoolclient-0.1.4a
hard linking setup.py -> mozpoolclient-0.1.4a
hard linking mozpoolclient.egg-info/PKG-INFO -> mozpoolclient-0.1.4a/mozpoolclient.egg-info
hard linking mozpoolclient.egg-info/SOURCES.txt -> mozpoolclient-0.1.4a/mozpoolclient.egg-info
hard linking mozpoolclient.egg-info/dependency_links.txt -> mozpoolclient-0.1.4a/mozpoolclient.egg-info
hard linking mozpoolclient.egg-info/requires.txt -> mozpoolclient-0.1.4a/mozpoolclient.egg-info
hard linking mozpoolclient.egg-info/top_level.txt -> mozpoolclient-0.1.4a/mozpoolclient.egg-info
Writing mozpoolclient-0.1.4a/setup.cfg
creating dist
Creating tar archive
removing 'mozpoolclient-0.1.4a' (and everything under it)
armenzg@UbuntVM:~/repos/mozpool/mozpoolclient$ ls dist/
mozpoolclient-0.1.4a.tar.gz
armenzg@UbuntVM:~/repos/mozpool/mozpoolclient$ sudo pip install dist/mozpoolclient-0.1.4a.tar.gz 
[sudo] password for armenzg: 
Unpacking ./dist/mozpoolclient-0.1.4a.tar.gz
  Running setup.py egg_info for package from file:///home/armenzg/repos/mozpool/mozpoolclient/dist/mozpoolclient-0.1.4a.tar.gz
    
Requirement already satisfied (use --upgrade to upgrade): requests>=1.0.0 in /usr/lib/python2.7/dist-packages (from mozpoolclient==0.1.4a)
Installing collected packages: mozpoolclient
  Found existing installation: mozpoolclient 0.1.2
    Uninstalling mozpoolclient:
      Successfully uninstalled mozpoolclient
  Running setup.py install for mozpoolclient
    
Successfully installed mozpoolclient
Cleaning up...
armenzg@UbuntVM:~/repos/mozpool/mozpoolclient$ python
Python 2.7.5+ (default, Sep 19 2013, 13:48:49) 
[GCC 4.8.1] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import mozpoolclient
>>>

Comment 3

[Justin Wood (:Callek)]

(In reply to Armen Zambrano [:armenzg] (Release Engineering) (EDT/UTC-4) from comment #2)
> Comment on attachment 828914 [details] [diff] [review]
> [mozpool] v1
> 
> Review of attachment 828914 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks for figuring this out!
> Why did you append "a" to the version number? Does that have some implicit
> meaning?

Merely because .1.3 is on pypi and we're not ready for .1.4 yet, .1.4a is < .1.4 in version numbers so that's why.

https://hg.mozilla.org/build/mozpool/rev/64af1082cf24