936272 - Avoid calling mkdir() from content process in form mochitests.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: bugNNNNNN-seccomp-mochitest-mkdir.diff

Context: I'm trying to get mochitests to pass on the B2G emulator with content process sandboxing (seccomp-bpf) enabled, so that we can enable sandboxing in TBPL.  Currently we're allowing open(), but the eventual plan is to make its callers request file access through the parent process, and we don't allow a content process to call mkdir().

Problem: Some of the forms tests use FileUtils to create files (either via MockFilePicker.useAnyFile or directly), and FileUtils tries to create a file's enclosing directory even if it already exists.

I've attached one possible solution, which avoids trying to create TmpD, under the assumption that it will already exist at this point.  I've tested this assumption with a try run: https://tbpl.mozilla.org/?tree=Try&rev=508f4e0290c1

Thoughts?

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 828969 [details] [diff] [review]
bugNNNNNN-seccomp-mochitest-mkdir.diff

I'm thinking we can check this in now, to unblock getting seccomp on tinderbox, and fix things for real later.

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: bug936272-seccomp-mochitest-mkdir-hg1.diff

Improving commit message; content of patch unchanged.  Carrying over r=sicking.

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

→ b2g-inbound.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9304d400684

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b9304d400684