936309 - [FDN] "Add contact" is broken

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Fabien Cazenave [:kaze]]

STR:
 • Settings > Call Settings > Fixed dialing numbers
 • make sure FDN is enabled
 • Authorized numbers
 • add a new FDN contact, tap [OK]
 • enter the correct PIN2

Expected:
 • contact is added to the FDN contact list

Actual:
 • the FDN contact list is not changed

Tested with Gecko 28 (20131106164831) and Gaia master (ac2c668).

This might be a Gecko regression: it looks like the `navigator.mozIccManager.updateContact' method works fine when updating a contact but does not allow to create a new contact any more.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I'll check this, 
thanks Kaze.

Comment 2

[Fabien Cazenave [:kaze]]

Thank *you*! :-)

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Just flashed latest gaia, seems met Bug 936324 now.

Kaze, I cannot find the gaia commit in Comment 0, (ac2c668)

$git checkout ac2c668
error: pathspec 'ac2c668' did not match any file(s) known to git.

Comment 4

[Fabien Cazenave [:kaze]]

Ugh, 'ac2c668' is my local branch. :-$

I meant “latest Gaia”. E.g. this bug still happens with Gaia 275ca2c.
https://github.com/mozilla-b2g/gaia/commit/275ca2c

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Kaze, can you show me your gecko commit as well? seems the keyboard is broken now and it's caused by gecko. (From the comment in Bug 936324) :(

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #5)
> Kaze, can you show me your gecko commit as well? seems the keyboard is
> broken now and it's caused by gecko. (From the comment in Bug 936324) :(

Never mind, I got it from Bug 936324 now.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

The problem is in ril_worker.js, contact.id is undefined. So calling startsWith will cause TypeError.

Previous in Bug 915987 could work because in RILContentHelper.js, mozContact.id is "undefined", (typeof(contact.id) = "string"), now since MozContact has been WebIDLized, so RILContentHelper.js receives undefined (typeof(contact.id) = "undefined"), so causes this bug. However even mozContact is WebIDLized, when running Marionette test, RILContentHelper still gets "undefined" (string) when reading contact.id.

Will write a simple patch do check contact.id.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 830127 [details] [diff] [review]
Patch

Review of attachment 830127 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +918,5 @@
>      }
>  
>      let contact = options.contact;
>      let iccid = RIL.iccInfo.iccid;
> +    if (typeof (contact.contactId) === "string" &&

nit: 'typeof' is an operator, just have |typeof foo === "string"|.

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Filed the Marionette problem in Bug 937440

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2

using typeof foo

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

try 
https://tbpl.mozilla.org/?tree=Try&rev=ccb2755be2da

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/0c668fc30eef

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0c668fc30eef