936339 - Use OMTC for b2g desktop

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nick Cameron [:nrc]]

Main thread OpenGL will soon not be an option and OMTC is closer to what we run on devices anyway.

Try run looks OK: https://tbpl.mozilla.org/?tree=Try&rev=78615a853811

I'm not sure how to test this any better though - I have not managed to get desktop b2g working for about a year.

Comment 1

[Nick Cameron [:nrc]]

Attachment: change prefs

Comment 2

[Nick Cameron [:nrc]]

I would like to get more people aware of this, particularly people who know about b2g desktop, but not sure who that is. It would be great if you could cc/needinfo the right people. Thanks!

Comment 3

[[:fabrice] Fabrice Desré]

Nick, this is basically what we do in bug 914584 except that we only enable on mac and linux because no-one tested on windows for real.

Comment 4

[Nick Cameron [:nrc]]

(In reply to Fabrice Desré [:fabrice] from comment #3)
> Nick, this is basically what we do in bug 914584 except that we only enable
> on mac and linux because no-one tested on windows for real.

Ah, perfect! (FWIW it should be safe to do this on Windows too, if not now, then very soon).

Comment 5

[Nick Cameron [:nrc]]

Attachment: patch

Reopened this bug to turn on OMTC for b2g desktop without all the other OOP issues in bug 914584

Comment 6

[[:fabrice] Fabrice Desré]

Comment on attachment 8337517 [details] [diff] [review]
patch

Review of attachment 8337517 [details] [diff] [review]:
-----------------------------------------------------------------

Don't you want to also set layers.offmainthreadcomposition.async-animations to true?

Comment 7

[Nick Cameron [:nrc]]

(In reply to Fabrice Desré [:fabrice] from comment #6)
> Comment on attachment 8337517 [details] [diff] [review]
> patch
> 
> Review of attachment 8337517 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Don't you want to also set layers.offmainthreadcomposition.async-animations
> to true?

I guess we eventually want that to be true, but it doesn't block anything, so for my needs is unnecessary. I figured it was best to leave that as part of bug 914584.

Comment 8

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1dd4d55f3f0

https://hg.mozilla.org/mozilla-central/rev/b1dd4d55f3f0