936370 - [Messaging] Scrolling issues and reduce unnecessary calls for updating UI.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Borja Salguero [:borjasalguero]]

Too calls to 'scrollToBottom' are forcing the scroll even in scenarios that there is no need to do it (for example, everytime we type a character, we are forcing the scroll of the entire container). Performance issues related.

Comment 1

[Borja Salguero [:borjasalguero]]

For performance, I will remove mutation observer as there is no need of using them (we can use a direct call to the function 
instead)

Comment 2

[Borja Salguero [:borjasalguero]]

Attachment: Pull request

Comment 3

[Rick Waldron [:rwaldron]]

Comment on attachment 829209 [details]
Pull request

In future, can you paste only the link to the pull request? Bugzilla knows to automatically link that now

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 829209 [details]
Pull request

Rick will handle this review :)

Comment 5

[Rick Waldron [:rwaldron]]

Comment on attachment 829209 [details]
Pull request

Please address comments from @julienw and mine, thanks!

Comment 6

[Rick Waldron [:rwaldron]]

Comment on attachment 829209 [details]
Pull request

two comments to fix then I can test again 

- https://github.com/mozilla-b2g/gaia/pull/13512/files#r7673338
- https://github.com/mozilla-b2g/gaia/pull/13512/files#r7672975

Comment 7

[Borja Salguero [:borjasalguero]]

Comment on attachment 829209 [details]
Pull request

Comments addressed, r?

Comment 8

[Rick Waldron [:rwaldron]]

The light is green! https://travis-ci.org/mozilla-b2g/gaia/builds/13993634

r=me

Comment 9

[Borja Salguero [:borjasalguero]]

https://github.com/mozilla-b2g/gaia/commit/c7e5c93e0f4151be38269e08df148cd9906ef0e7
https://github.com/borjasalguero/gaia/commit/281c345d48d556aa7ef943d84a7af912454bb920
R+. Merged!

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

already in master. clear flag