Closed
Bug 936373
Opened 11 years ago
Closed 11 years ago
Optimize FB datastore index refresh by tracking revisionId number
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 Sprint 5 - 11/22
People
(Reporter: jmcf, Assigned: jmcf)
References
Details
Attachments
(1 file)
Currently when a record is not found on the FB datastore we try to refresh the idnex just in case another app modified the DS. This can be more efficient if we track datastore revisionId and we only refresh the index when we know there has been a change i.e. revisionId is different.
|
Assignee | |
Updated•11 years ago
|
Blocks: move-fb-to-datastore
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #829889 -
Flags: review?(crdlc)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 829889 [details]
13554.html
Just a comment, thanks Jose
Attachment #829889 -
Flags: review?(crdlc) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/a26a670b9bb1dc281a8f6a144f580dba9e831e04
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Comment 4•11 years ago
|
||
This needs to be backed out - this broke a smoketest with using facebook import for the contacts app. John - Can you back this out?
Flags: needinfo?(jhford)
|
|
Assignee | |
Comment 5•11 years ago
|
||
:jsmith what smoke test is breaking this patch? Are you sure that this patch is responsible for? Please DO NOT back out anything without counting on the dev team. thanks
|
|
Assignee | |
Updated•11 years ago
|
Flags: needinfo?(jhford)
|
|
Assignee | |
Comment 6•11 years ago
|
||
As I reported on bug 937361 comment #6 this HAS NOT TO BE BACKOUT as it has not caused recent regressions on Facebook integration. thanks
You need to log in
before you can comment on or make changes to this bug.
Description
•