Optimize FB datastore index refresh by tracking revisionId number

RESOLVED FIXED in 1.3 Sprint 5 - 11/22

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jmcf, Assigned: jmcf)

Tracking

unspecified
1.3 Sprint 5 - 11/22
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Currently when a record is not found on the FB datastore we try to refresh the idnex just in case another app modified the DS. This can be more efficient if we track datastore revisionId and we only refresh the index when we know there has been a change i.e. revisionId is different.
(Assignee)

Updated

5 years ago
Blocks: 918827
(Assignee)

Comment 1

5 years ago
Created attachment 829889 [details]
13554.html
Attachment #829889 - Flags: review?(crdlc)
Comment on attachment 829889 [details]
13554.html

Just a comment, thanks Jose
Attachment #829889 - Flags: review?(crdlc) → review+
(Assignee)

Comment 3

5 years ago
https://github.com/mozilla-b2g/gaia/commit/a26a670b9bb1dc281a8f6a144f580dba9e831e04
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 937361
This needs to be backed out - this broke a smoketest with using facebook import for the contacts app.

John - Can you back this out?
Flags: needinfo?(jhford)
(Assignee)

Comment 5

5 years ago
:jsmith

what smoke test is breaking this patch? Are you sure that this patch is responsible for?

Please DO NOT back out anything without counting on the dev team.

thanks
(Assignee)

Updated

5 years ago
Flags: needinfo?(jhford)
(Assignee)

Updated

5 years ago
No longer depends on: 937361
(Assignee)

Comment 6

5 years ago
As I reported on bug 937361 comment #6 this HAS NOT TO BE BACKOUT as it has not caused recent regressions on Facebook integration. thanks
already in master. clear flag
blocking-b2g: 1.3? → ---
You need to log in before you can comment on or make changes to this bug.