Closed Bug 936478 Opened 9 years ago Closed 8 years ago

Test failure "controller.waitForPageLoad(): Timeout waiting for page loaded" in /testSecurity/testSafeBrowsingWarningPages.js

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cosmin-malutan, Assigned: danisielm)

References

()

Details

(Keywords: intermittent-failure, Whiteboard: [mozmill-test-failure])

Attachments

(4 files, 1 obsolete file)

It didn't reproduce on the affected machine.
Some additional information.

The page where we get redirected from google:
http://safebrowsing.clients.google.com/safebrowsing/diagnostic?client=Firefox&hl=en-US&site=http://www.mozilla.org/firefox/its-an-attack.html

Looks different from the last time we saw it.
It could be that google recently (just now?) updated it we we caught some CDN refresh problems?
This has failed lots of times today (~15 times)
We should try again to look into it.
Priority: P3 → P2
Assignee: nobody → mario.garbi
Status: NEW → ASSIGNED
I have tried to reproduce it on CI machines (XP and Linux) but without much luck, I will continue the investigation and hopefully I can witness a failure by observing the machines running remote testruns today.
Status: ASSIGNED → NEW
I wouldn't spend too much time on it given that we hopefully can upgrade to mozmill 2 soon.
I tried to reproduce this failure on the failing CI machines mm-win-8-64-3 and mm-ub-1304-4 and was not able even though the failured keep happening. This might be related to a Jenkins setting since by logging on the machine and triggering a testrun_remote script won't reproduce it even once.
Judging by Henrik's comment this might be fixed in Mozmill 2.0 and will focus on other bugs.
Attached patch skip.patch (obsolete) — Splinter Review
We need to get this skipped, way to many failures.
Attachment #8335867 - Flags: review?(andreea.matei)
Comment on attachment 8335867 [details] [diff] [review]
skip.patch

Review of attachment 8335867 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, it's not applying anymore due to bug 905033.
Attachment #8335867 - Flags: review?(andreea.matei) → review-
Status: NEW → ASSIGNED
Attached patch skip_2.patchSplinter Review
Updated skip patch to apply cleanly again :)
Attachment #8335867 - Attachment is obsolete: true
Attachment #8335930 - Flags: review?(andreea.matei)
Comment on attachment 8335930 [details] [diff] [review]
skip_2.patch

Review of attachment 8335930 [details] [diff] [review]:
-----------------------------------------------------------------

Disabled:
http://hg.mozilla.org/qa/mozmill-tests/rev/b3fe63f861e0 (default)
Attachment #8335930 - Flags: review?(andreea.matei) → review+
And aurora:
http://hg.mozilla.org/qa/mozmill-tests/rev/971bf49d48e6 (aurora)
Whiteboard: [mozmill-test-failure][mozmill-test-skipped]
I can still reproduce this on Aurora branch, I will investigate it and come with more info.
Assignee: mario.garbi → daniel.gherasim
This is a remote test and I run it today for 500 times on latest nightly with Windows 8.1. No failure at all.

My guess here is that it fails sometimes when accessing https://support.mozilla.org/en-US/kb/how-does-phishing-and-malware-protection-work?as=u&utm_source=inproduct because of the 
ssl.google-analytics service timeout. I now that's a known issue with that service.

With the new Mozmill version we can find out exactly what's failing, so let's get it unskipped and see how it's running.

This skip patch applies cleanly on nightly and aurora.
Attachment #8399425 - Flags: review?(andrei.eftimie)
Attachment #8399425 - Flags: review?(andreea.matei)
We wont see if Ajax requests are hanging.
Failed 3 times with Beta 29.0b4 en-US, at waiting for about:blank it appears, this is the line affected:
http://hg.mozilla.org/qa/mozmill-tests/file/mozilla-beta/firefox/tests/remote/testSecurity/testSafeBrowsingNotificationBar.js#l119

This is not disabled on beta anymore, I guess do to the merge.
Summary: Test failure "controller.waitForPageLoad(): Timeout waiting for page loaded" /testSecurity/testSafeBrowsingWarningPages.js → Test failure "controller.waitForPageLoad(): Timeout waiting for page loaded (URI=about:blank, readyState=uninitialized)" in /testSecurity/testSafeBrowsingWarningPages.js
So this might be because when a new tab gets opened about:blank is the first page which gets loaded, and replaced right after with the target page. Is that something we can create a minimized testcase for to get it reproduced? Wouldn't we have to wait for the new tab being opened first?
(In reply to Andreea Matei [:AndreeaMatei] from comment #17)
> Failed 3 times with Beta 29.0b4 en-US, at waiting for about:blank it
> appears, this is the line affected:
> http://hg.mozilla.org/qa/mozmill-tests/file/mozilla-beta/firefox/tests/
> remote/testSecurity/testSafeBrowsingNotificationBar.js#l119

I can see that this is another test then the one from this bug's title.
Oh, you're right, my bad. I'll open a new bug for this and eventually make it general for "about:blank" failures.
Summary: Test failure "controller.waitForPageLoad(): Timeout waiting for page loaded (URI=about:blank, readyState=uninitialized)" in /testSecurity/testSafeBrowsingWarningPages.js → Test failure "controller.waitForPageLoad(): Timeout waiting for page loaded" in /testSecurity/testSafeBrowsingWarningPages.js
Comment on attachment 8399425 [details] [diff] [review]
bug_936478_unskip.patch

Review of attachment 8399425 [details] [diff] [review]:
-----------------------------------------------------------------

Let's unskip on default and see if we're still seeing failures.

Unskipped:
http://hg.mozilla.org/qa/mozmill-tests/rev/5b5d72d07722 (default)
Attachment #8399425 - Flags: review?(andrei.eftimie)
Attachment #8399425 - Flags: review?(andreea.matei)
Attachment #8399425 - Flags: review+
Attachment #8399425 - Flags: checkin+
In another 500 runs on windows 8.1 and 100 on Mac OSX 10.6 I haven't seen any failure.
What are we waiting for here? I see no action since April 1st.
Transplanted:
http://hg.mozilla.org/qa/mozmill-tests/rev/9a4d1b030cd7 (mozilla-aurora)

Daniel, please backport this patch on the rest of the branches.
Flags: needinfo?(daniel.gherasim)
Unskip patch for release.
Attachment #8403805 - Flags: review?(andrei.eftimie)
Attachment #8403805 - Flags: review?(andreea.matei)
Flags: needinfo?(daniel.gherasim)
Comment on attachment 8403803 [details] [diff] [review]
bug_936478_unskip_beta.patch

Review of attachment 8403803 [details] [diff] [review]:
-----------------------------------------------------------------

Please make sure to have the bug number mentioned in the commit messages.
Pushed:
http://hg.mozilla.org/qa/mozmill-tests/rev/993f25aa9e28 (beta)
Attachment #8403803 - Flags: review?(andrei.eftimie)
Attachment #8403803 - Flags: review?(andreea.matei)
Attachment #8403803 - Flags: review+
Comment on attachment 8403805 [details] [diff] [review]
bug_936478_unskip_release.patch

Review of attachment 8403805 [details] [diff] [review]:
-----------------------------------------------------------------

Pushed:
http://hg.mozilla.org/qa/mozmill-tests/rev/d49557ae0b30 (release)
Attachment #8403805 - Flags: review?(andrei.eftimie)
Attachment #8403805 - Flags: review?(andreea.matei)
Attachment #8403805 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [mozmill-test-failure][mozmill-test-skipped] → [mozmill-test-failure]
Please do not reopen bugs which have been fixed a long time ago. Create new ones instead. They are cheap. Sadly I cannot revert the status flags.
Status: REOPENED → RESOLVED
Closed: 9 years ago8 years ago
Resolution: --- → FIXED
(In reply to Henrik Skupin (:whimboo) from comment #30)
> Please do not reopen bugs which have been fixed a long time ago. Create new
> ones instead. They are cheap. Sadly I cannot revert the status flags.

This bug was not fixed. Should have been closed with WFM. Those flags only reflect disabled status.
Test was unskipped in April, we have failures from April up until now.
Oh, I see. But please open a new bug.  This one has already about 30 comments and will only confuse.
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.