936485 - [system] Intermittent Travis Marionette JS Failure: Notification.get(): notifications should persist even after closing app: Error: timeout exceeded!

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Julien Wajsberg [:julienw]]

1) Notification.get(): notifications should persist even after closing app:

Error: timeout exceeded!

at Object.Client.waitForSync (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:677:16)

at Object.Client.waitFor (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:646:60)

at Object.waitUntilClosed (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/close.js:46:12)

at Object.Client._handleCallback (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:480:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:506:21

at TcpSync.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:94:10)

at Object.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:453:36)

at Object.Client._sendCommand (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:499:19)

at Object.switchToFrame (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:868:19)

at Object.switchToRoot (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/close.js:35:12)

at Object.Client._handleCallback (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:480:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:506:21

at TcpSync.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:94:10)

at Object.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:453:36)

at Object.Client._sendCommand (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:499:19)

at Object._executeScript (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1446:19)

at Object.executeScript (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1186:19)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/close.js:73:19

at Object.<anonymous> (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/switchtoapp.js:31:16)

at Object.Client._handleCallback (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:480:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:506:21

at TcpSync.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:94:10)

at Object.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:453:36)

at Object.Client._sendCommand (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:499:19)

at Object.switchToFrame (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:868:19)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/switchtoapp.js:30:21

at waitForAppSync (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/waitforapp.js:45:15)

at waitForApp (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/waitforapp.js:23:5)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/switchtoapp.js:25:12

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/getapp.js:83:12

at Object.<anonymous> (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/mgmt.js:58:14)

at Object.Client._handleCallback (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:480:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:506:21

at TcpSync.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:94:10)

at Object.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:453:36)

at Object.Client._sendCommand (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:499:19)

at Object._executeScript (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1446:19)

at Object.executeAsyncScript (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1227:19)

at Object.Mgmt.getAll (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/mgmt.js:37:19)

at list (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/list.js:14:20)

at getApp (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/getapp.js:45:10)

at switchToApp (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/switchtoapp.js:20:10)

at close (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/close.js:65:10)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/system/test/marionette/notification_get_test.js:171:17)

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

How often are we seeing this happening? Is it worth skipping this test for now until we can figure out what's going on?

Also, it looks like the timeout occurs on an `client.apps.close` call. Perhaps we can increase the timeout for this.

Comment 2

[Julien Wajsberg [:julienw]]

Travis and TBPL runs in very constrained VMs, so it probably makes sense to increase the default timeout for async operations, yes. Please increase them a lot ;) I don't like intermittent, especially stupid ones like this one!

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: GH PR, increase waitFor timeout

Increasing waitFor timeout from 10 to 20 seconds should help with some of the intermittent issues.

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/31e549b4b672cf6491cbf73da8039873d618c798

Let's see if we see this issue again before closing the bug.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 831008 [details] [review]
GH PR, increase waitFor timeout

lightsofapollo gave his blessing over IRC :)

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Still seeing this issue. Will need to increase timeout again.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: Re-enable tests

All notification.get tests were disabled in bug 952611 because of this bug. So I will use this bug to re-enable those tests.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

20 runs, 20 greens: https://travis-ci.org/mozilla-b2g/gaia/builds/16884570
I think we are ready to re-enable these.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8359331 [details] [review]
Re-enable tests

Gareth, can I have your blessing to put these back?

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/4447def31a77fbeee05cf9d96d1de6651aa715fe