Closed
Bug 936522
Opened 12 years ago
Closed 12 years ago
Move preferences-related classes to the preferences package
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: lucasr, Assigned: lucasr)
Details
Attachments
(1 file)
46.16 KB,
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
We have a bunch of preference-specific classes that should all be the preferences package.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → lucasr.at.mozilla
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #829416 -
Flags: review?(liuche)
Comment 2•12 years ago
|
||
Comment on attachment 829416 [details] [diff] [review]
Move preference-related to the preferences package (r=liuche)
Review of attachment 829416 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good! I don't see any other files that would need to be moved, except possibly PrefsHelper and SharedPreferencesHelper, but those are also fine separate (since they aren't actually preferences elements).
There's a little bit of bitrot in moz.build and probably elsewhere when applied to fx-team, but r+ when that's all fixed.
Attachment #829416 -
Flags: review?(liuche) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Comment 5•12 years ago
|
||
This touches files managed in the android-sync repo (namely, background/common/GlobalConstants.java.in). I'm going to land this small change in android-sync.
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•