Closed Bug 936522 Opened 12 years ago Closed 12 years ago

Move preferences-related classes to the preferences package

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: lucasr, Assigned: lucasr)

Details

Attachments

(1 file)

We have a bunch of preference-specific classes that should all be the preferences package.
Assignee: nobody → lucasr.at.mozilla
Attachment #829416 - Flags: review?(liuche)
Comment on attachment 829416 [details] [diff] [review] Move preference-related to the preferences package (r=liuche) Review of attachment 829416 [details] [diff] [review]: ----------------------------------------------------------------- This looks good! I don't see any other files that would need to be moved, except possibly PrefsHelper and SharedPreferencesHelper, but those are also fine separate (since they aren't actually preferences elements). There's a little bit of bitrot in moz.build and probably elsewhere when applied to fx-team, but r+ when that's all fixed.
Attachment #829416 - Flags: review?(liuche) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
This touches files managed in the android-sync repo (namely, background/common/GlobalConstants.java.in). I'm going to land this small change in android-sync.
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: