936593 - Allow overriding button's active color

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Currently we set the :active state on buttons to a background-color: gray !important. Because we use important, its pretty tough (impossible?) to override. We should remove the if we don't need it.

We're competing with styles in forms.css, so we may have needed the !important for that. If thats the case, we should try to find a way around it, but I have a feeling this is just hold-over from a mistake.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

This works fine on a simple test page. I think we should take it on nightly for a bit to test.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

Now with code!

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 829442 [details] [diff] [review]
Patch

Let's try it

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/531c1cc429f8

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/531c1cc429f8

Comment 6

[Aaron Train [:aaronmt]]

See bug 945251