936738 - `uniform{2,3,4}i` should not check for valid sampler texUnit values

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

`uniform{2,3,4}i` should not check for valid sampler texUnit values, because all `uniform**` calls other than `uniform1i` generate INVALID_OPERATION when called on the location of a sampler.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: no-multi-sampler-uniforms

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 829654 [details] [diff] [review]
no-multi-sampler-uniforms

Review of attachment 829654 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but should we then check ourselves that the uniform isn't a sampler? Or should we trust the driver for that?

Comment 3

[Kelsey Gilbert [:jgilbert]]

(In reply to Benoit Jacob [:bjacob] from comment #2)
> r=me, but should we then check ourselves that the uniform isn't a sampler?
> Or should we trust the driver for that?

So far we just trust the driver. I think this is probably fairly safe, since this is a fairly straight-forward part of the spec. In the absence of known driver issues, let's just hand this off to the driver.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0afa48bc2c3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c0afa48bc2c3