Closed
Bug 936993
Opened 11 years ago
Closed 11 years ago
reduce register pressure around MCheckOverRecursed
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: sunfish, Assigned: sunfish)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
2.05 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
The IonBuilder currently creates an MCheckOverRecursed instruction after doing some unboxing of arguments. The MCheckOverRecursed has an OSI point which uses the boxed values, so this means that the lifetimes of the boxed and unboxed values overlap, which creates unnecessary register pressure. Attached is a patch which moves the MCheckOverRecursed to before the unboxing begins. This reduces spilling in some cases under the backtracking allocator, especially after the change to avoid spilling to argument slots (bug 931487).
Attachment #830015 -
Flags: review?(bhackett1024)
|
||
Updated•11 years ago
|
Attachment #830015 -
Flags: review?(bhackett1024) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d726198d704
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3d726198d704
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•