937005 - Xulrunner 26 unresolved external symbol __imp__PR_sscanf

Status: VERIFIED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Mohd Rozi]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.76 Safari/537.36

Steps to reproduce:

1) Download Xulrunner SDK from http://ftp.mozilla.org/pub/mozilla.org/xulrunner/releases/26.0b3/sdk/xulrunner-26.0b3.en-US.win32.sdk.zip



Actual results:

nss3.lib is missing in xulrunner 26

Below is a compiler output (VS2010) :

xpcomglue_s_nomozalloc.lib(nsStringAPI.obj) : error LNK2001: unresolved external symbol __imp__PR_sscanf 
xpcomglue_s_nomozalloc.lib(nsCRTGlue.obj) : error LNK2001: unresolved external symbol __imp__PR_Now 
C:\26litmus-ff .dll : fatal error LNK1120: 2 unresolved externals 


Expected results:

Program should compiled OK using latest SDK (xulrunner 26)

Comment 1

[Benjamin Smedberg]

It's true that the SDK doesn't seem to contain a nss3.lib files which is where these NSPR functions should be present.

Glandium, thoughts?

Comment 2

[Mike Hommey [:glandium]]

It means we have a missing SDK_LIBRARY definition in security/build/Makefile.in

Comment 3

[Mike Hommey [:glandium]]

Attachment: Install folded import library in the SDK

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1a38c3857d0

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f1a38c3857d0

Comment 7

[Reinhold Degenfellner]

does mozilla28 mean that you intend to apply this fix to xulrunner 28 at the earliest?
That what be a real pain for all who relay on the sdks to be complete.

Comment 8

[(not currently active) Ted Mielczarek]

It means that it's fixed for the Firefox 28 release (which we'll ship a Xulrunner 28 alongside). If no other action is taken, that's the earliest the fix will ship.

This patch is pretty simple, we could probably take it on an earlier release to fix the problem. glandium: do you want to try to get this on aurora/beta?

Comment 9

[Mike Hommey [:glandium]]

Turns out this is also not actually fixed.

Comment 10

[Mike Hommey [:glandium]]

Attachment: Make the original fix actually do something

Comment 11

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/2cc86a28ff05

Comment 12

[Mike Hommey [:glandium]]

Attachment: Install folded import library in the SDK.

This is the combined patch for branches.

Comment 13

[Mike Hommey [:glandium]]

Comment on attachment 8342108 [details] [diff] [review]
Install folded import library in the SDK.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 648407
User impact if declined: Impossible to build binary components for firefox on windows with the SDK.
Testing completed (on m-c, etc.): Landed actual fix on m-c today, got a xulrunner nightly triggered, and verified the SDK contents.
Risk to taking this patch (and alternatives if risky): The patch only makes us copy one more file to dist/sdk during the build. This doesn't affect the resulting firefox builds. The only thing this affects is the SDK we create on xulrunner builds. It's probably too late on beta for firefox, but maybe it's not for xulrunner?
String or IDL/UUID changes made by this patch: None

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8342108 [details] [diff] [review]
Install folded import library in the SDK.

[Triage Comment]
Since this does not affect builds, please go ahead with uplift but also uplift to mozilla-release branch so that, if necessary, it's in any respins for 26.0

Comment 15

[Brian Slesinsky]

If it's just that the library is missing, would copying nss3.lib from 25.0.1 be a reasonable way to get it to build?

Comment 16

[Mike Hommey [:glandium]]

Likely not.

Comment 17

[Brian Slesinsky]

Hmm, I tried it and my plugin builds and runs, so far.

Comment 18

[Brian Slesinsky]

The same issue happens on the Mac. I created a separate bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=946558

Comment 20

[Mike Hommey [:glandium]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/21ef58290c6a
https://hg.mozilla.org/releases/mozilla-release/rev/e72dc12f4eaf

beta is closed, and i /think/ it's fine not to land there, since aurora, which now has it will be merged there, and nothing is supposed to happen on beta before that.

Not sure how to update the status flags, considering it may or may not make it to 26.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Does this need to land on b2g26?

Comment 22

[Mike Hommey [:glandium]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #21)
> Does this need to land on b2g26?

No

Comment 23

[u279076]

Mohd Rozi, please confirm this is fixed for you now in Firefox 28 (aurora), Firefox 27 (beta), and Firefox 26 (release)

Comment 24

[Mohd Rozi]

Yes, confirmed. Everything is OK now.

Comment 25

[u279076]

Thanks Mohd.