937082 - [STK] Speedup ICC messages processing

Status: RESOLVED DUPLICATE of bug 951599

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

STK (ICC) messages can be received at any time. Some of them are managed by settings app.

Some time ago, ICC settings view was hidden until it was selected so a grace timeout was applied to assure ICC page is loaded:

https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/icc_menu.js#L23
    // Open ICC section
    DUMP('ICC command to execute: ', iccCommand);
    Settings.currentPanel = '#icc';

    setTimeout(function() {
      var event = new CustomEvent('stkasynccommand', {
        detail: { 'command': iccCommand }
      });
      window.dispatchEvent(event);
    }, 2000);


Currently it's no more needed since currently ICC page is always loaded (Bug 842215). https://github.com/mozilla-b2g/gaia/commit/a33ee932443330494328006df30e048f2dfe6e98

If we remove this timer, STK operations will be faster and code cleaner ;)

Comment 2

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Really improved the STK performance with the patch in 951599 (https://github.com/mozilla-b2g/gaia/commit/83197dc6f9ad88780f1fcbc3b01ee55756f566d6)

So this bug is no more needed :)