937205 - [B2G][Contacts] Contact picture does not display after Linking and Favoriting a Facebook contact

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Darren]

Attachment: missing facebook picture.jpg

Repro Steps:
1. Updated Buri Build ID: 20131111004004
2. Open Contacts app
3. Tap on the Settings icon(Gear Icon)
4. Toggle on Sync Facebook
5. Input valid credentials
6. Import a contact with a picture
7. Link a local contact with the imported Facebook contact
8. Favorite the Facebook linked contact
9. Close and reopen the Contacts app

Actual Results:
Only one instance of the contact has the Facebook picture.

Expected Results:
Both instances of the contact will display any picture assigned to the contact. 

Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20131111004004
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/1ac147e4e2f0
Gaia: 670b2c8329bca6f142939185be71274166d82bb8
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Base Build: 20131104

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.1?

Comment 2

[Matthew Vaughan]

This issue does NOT reproduce on the 11/7/2013 1.1 build.

Environmental Variables:
Device: Leo v1.1 MOZ RIL
BuildID: 20131107041203
Gaia: 39b0203fa9809052c8c4d4332fef03bbaf0426fc
Gecko: 31fa87bfba88
Version: 18.0

Comment 3

[Matthew Vaughan]

This issue started reproducing on the 8/01/2013 1.2 build. 

- Works -
Environmental Variables:
Device: Buri v1.2 MOZ RIL
BuildID: 20130731030205
Gaia: 9bfceaa90e8b92a379432b67121afa3cd3f14c90
Gecko: c2b375f3a909
Version: 25.0a1

- Broken -
Environmental Variables:
Device: Buri v1.2 MOZ RIL
BuildID: 20130801030224
Gaia: c1620a242c937c7fcb171b88c85ef63561165081
Gecko: 05d3797276d3
Version: 25.0a1

Comment 4

[Preeti Raghunath(:Preeti)]

David,

Can you please look into this bug as it is in the contacts area?

Comment 5

[Jason Smith [:jsmith]]

The only related patches in the regression range that seem relevant here are:

https://github.com/mozilla-b2g/gaia/commit/b2fd9f43a66d4dbddcb908dc1159ef2b82be2de2

https://github.com/mozilla-b2g/gaia/commit/f65a65b6972c9c2d19aab0d227ec2aba61e3143b

Comment 6

[bhavana bajaj [:bajaj]]

:jose,Do we know what the next steps here are ?

We may have to backout, disable the user story this is needed for( https://bugzilla.mozilla.org/show_bug.cgi?id=899525) in case forward fix is risky, given the timeline we have for 1.2

Comment 7

[bhavana bajaj [:bajaj]]

(In reply to Jason Smith [:jsmith] from comment #5)
> The only related patches in the regression range that seem relevant here are:
> 
> https://github.com/mozilla-b2g/gaia/commit/
> b2fd9f43a66d4dbddcb908dc1159ef2b82be2de2
> 
> https://github.com/mozilla-b2g/gaia/commit/
> f65a65b6972c9c2d19aab0d227ec2aba61e3143b

Poking :jose to seek help here based on the plausible culprit commits

Comment 8

[Jose Manuel Cantera]

I'm on it. ETA today

Comment 9

[Jose Manuel Cantera]

Attachment: 13837.html

Precenting race conditions in the fb_resolver

Comment 10

[Jose Manuel Cantera]

The bug also reproduces (not 100%) by favoriting imported FB Contacts. Once patch landes QA plwase verify also those test cases

Comment 11

[Jason Smith [:jsmith]]

(In reply to Jose M. Cantera from comment #10)
> The bug also reproduces (not 100%) by favoriting imported FB Contacts. Once
> patch landes QA plwase verify also those test cases

Sure - when it lands, can you mark verifyme in the keywords?

Comment 12

[Jose Manuel Cantera]

Ben,

This is a koi+, please could you help with the review ASAP?

thanks!

Comment 13

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Jose M. Cantera from comment #12)
> This is a koi+, please could you help with the review ASAP?

I will do it first thing this morning.  Sorry for the delay!

Comment 14

[Jose Manuel Cantera]

Attachment: 13874.html

Comment 15

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8335301 [details]
13874.html

Looks good, r=me.  Thanks!

Comment 16

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/f55c9746b9ae4a1aab739d6015ebff3cf51d21f3

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 f55c9746b9ae4a1aab739d6015ebff3cf51d21f3
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 18

[Germán Toro del Valle (:gtorodelvalle)]

Merged in v1.2: https://github.com/mozilla-b2g/gaia/commit/9e663205abe410cadff8c18d08a52150b0f4061f

Comment 19

[Noemí Freire (:noemi)]

patch already uplifted to v1.2 so clearing ni? flag

Comment 20

[Josh Schmitt [Joshs]]

Both instances of the contact now display the pictures assigned to the contact in the latest Buri v1.2 and Master 1.3 build.

1.2 Environmental Variables:
Device: Buri v1.2 COM RIL
BuildID: 20131204004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/244e98241b2c
Gaia: c8f14ad3950d59ba13d7639eff02d080060bb3ce
Version: 26.0
RIL Version: 01.02.00.019.102
Firmware Version: V1.2_20131115

1.3 Environmental Variables
Device: Buri v1.3 Mozilla RIL
Build ID: 20131203040236
Gecko: http://hg.mozilla.org/mozilla-central/rev/8648aa476eef
Gaia: 31808a29cfcffa584b6a88b4f1e515387f485a1b
Platform Version: 28.0a1
Firmware Version: v1.2_20131115