937233 - [B2G][System] "Remember my choice" prompt does not save the user's choice when launching full screen on youtube.com.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Lucas Aliaga]

When viewing a video on youtube.com in the browser, if the user toggles fullscreen and saves their choice, the prompt still displays on subsequent fullscreen launches.

Repro Steps:
1. Update Buri device to 1.3 buildID: 20131111040200.
2. Launch browser and navigate to youtube.com.
3. Watch a video and tap fullscreen.
4. Tap share/allow and remember choice.
5. Leave fullscreen then toggle it on again.

Actual Results:
The "Remember my choice" prompt appears again.

Expected Results:
Remember my choice to remember the user's preference when viewing youtube.com.

Repro Rate: 3/3 100%

Environment Variables:
BuildID: 20131111040200
Gecko: 	 bc8c1eb0f2ba
Gaia:	 bcb4f94524ef02e9ef16b604d16c39e5a9c41281

See attached: logcat
Add'l notes: Also occurs on 1.2

Comment 1

[Lucas Aliaga]

Attachment: Logcat_RememberChoice

Comment 2

[Jason Smith [:jsmith]]

Argh. This broke again - we don't support this use case, but we're exposing the UX. Must have been yet another visual design regression where someone turned this on unexpectedly...

Comment 3

[Lucas Aliaga]

Updating. It's actually 1.2 only.

Comment 4

[sarsenyev]

Unable to find a regression window during the design is changed.  After I flashed to a couple builds back, the prompt bar is disappear and never appeared again on any builds even on the build that has been reproducible before

Comment 5

[Jason Smith [:jsmith]]

(In reply to sarsenyev from comment #4)
> Unable to find a regression window during the design is changed.  After I
> flashed to a couple builds back, the prompt bar is disappear and never
> appeared again on any builds even on the build that has been reproducible
> before

I don't understand what this means.

Comment 6

[sarsenyev]

Attachment: 2013-11-12-14-19-20.png

To better understand the issue here the more details about my steps
1) I was able to reproduce it on the November 11 1.2 build, 
The prompt message appeared with "remember a user choice" option
2) To find a regression window I flashed to the earlier build, June 21,but the prompt message wasn't implemented yet for viewing in full screen
3) Then I flashed to September 16, to see if the prompt message has been implemented, the prompt message appeared but without "remembering" choice option
4) I flashed back to more builds to see the "remember my choice" option, but I couldn't see it
5) Then I flashed back to the November 11 build where I saw the "remember my choice option"
But it didn't appear, I don't see any "remember my choice" option on any build, design of the prompted message is different, with an option "Allow" "Deny" instead of "Share", "Don't share"
See the attachment how it looks now.

Comment 7

[Jason Smith [:jsmith]]

This is a works for me apparently - I can't reproduce this on today's build (11/12/2013 1.2).