937389 - [B2G][Settings] When the Caller ID is enabled or disabled using the dialer it will show incorrectly in settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: CLIRlogcat.txt

Description:
When the Caller ID is enabled or disabled using the dialer it will show incorrectly in settings. If the user dials *31# to show the number, it will show "Hide number" under Caller ID in settings. If the user dials #31# to hide the number, Caller ID in settings will show "Show number".

Repro Steps:
1)  Updated Buri to Build ID: 20131030004003
2)  Open the dialer and dial "*31#" and tap the green call button.
3)  Tap on the "Home button" phone and tap on the "Settings" icon.
4)  Tap on "Call Settings".
5)  Look at the setting under "Caller ID".
6)  Repeat steps 2 through 5 but dial "#31#" to hide the number instead of "*31#".

Actual:
Dialing *31# to show the number will show "Hide number" under Caller ID in settings and dialing "#31# to the hide the number will show "Show Number" under Caller ID in settings.

Expected:
The correct setting should be shown under Caller ID. When the user dials "*31#", the Caller ID should say "Show number" in settings. When the user dials "#31#", the Caller ID should say "Hide Number" in settings.

Environmental Variables
Device: Buri v 1.2.0 COM RIL
Build ID: 20131030004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/4fbe1b01ed63
Gaia: a788ea1a3e04716938bd41a559c36a831cf1190b
Platform Version: 26.0a2
RIL Version: 01.01.00.019.264 

Notes:
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/9574/
See attached: logcat

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue does not reproduce on Leo v 1.1.0 COM RIL

Environmental Variables
Device: Leo v 1.1.0 COM RIL
Build ID: 20131024041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/e4cb5a852e3d
Gaia: 39b0203fa9809052c8c4d4332fef03bbaf0426fc
Platform Version: 18.1
RIL Version: 01.01.00.019.264 

Caller ID is not in the settings on v 1.1.0

Comment 2

[Jason Smith [:jsmith]]

This feels like something that could be a cert blocker.

Al - Can you give assessment of how important this bug is for 1.2?

Comment 3

[Al Tsai [:atsai]]

This is a feature of v1.2. Please koi+ The bug. Thanks.

Comment 4

[Preeti Raghunath(:Preeti)]

koi+ since it is a broken 1.2 feature.

Comment 5

[bhavana bajaj [:bajaj]]

NI on Tim to help with an assignee on this blocker.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Arthur, do you know if this is a feature of our team? If so we need to fix this.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

It is an issue of settings app.

We refresh the setting when entering call settings panel. It seems like it does not handle the case of visibility change (switching apps).

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

According to Arthur this is not a bug on features we own, but it's an easy fix that he could provide a timely help.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/13740

Jose, could you help review the change? Thanks.

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 832856 [details]
link to https://github.com/mozilla-b2g/gaia/pull/13740

This issue is not a bug but a UX improvement. The call settings panel gets update every time the user opens it and all the items get newly updated. If we want to add this improvement I would refresh/update all the other items as well.

Arthur there is something wrong with the patch since once the visibility changes and the CLIR item gets update the call forwarding items get all disabled.

I would change a bit the pacth as below:

document.addEventListener('visibilitychange', function() {
  if (!document.hidden) {
    if (!updatingInProgress) {
      updateVoiceMailItemState();
      updateFdnStatus();
      updateCallerIdItemState(
	function panelready_updateCallerIdItemState() {
	  updateCallWaitingItemState(
	    function panelready_updateCallWaitingItemState() {
	      updateCallForwardingSubpanels();
	  });
      });
    }
  }
});

Comment 11

[Alex Keybl [:akeybl]]

This seems to be a very uncommon use case. These numbers are used to:

"block outgoing CND info for a single call on a mobile that is preset to automatically send CND information"

Triage does not believe that we should block on correctly presenting a setting that is only applied to the next phone call. pdol, agree?

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Jose, is it possible that voice mail, FDN settings get changed outside settings app? If no, maybe we should only update the caller ID state as it has less UI blocked time.

Comment 14

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Alex Keybl [:akeybl] from comment #11)
> Triage does not believe that we should block on correctly presenting a
> setting that is only applied to the next phone call. pdol, agree?

You made a wrong assumption, by dialing '*31#' or '#31#' the CLIR setting is set for all the outgoing calls not only for the next one. This bug is about permanent CLIR settings through MMI codes (bug 892498) not for temporary CLIR settings (bug 894871).

Comment 15

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Arthur Chen [:arthurcc] from comment #12)
> Jose, is it possible that voice mail, FDN settings get changed outside
> settings app?

No, it isn't (IIRC).
 
> If no, maybe we should only update the caller ID state as it
> has less UI blocked time.

We should block/disable (all together) call waiting, CLIR and call forwarding items while updating every time the user updates one of them. All these settings are handled by mozMobileConnection API and if we change any of them we should keep the rest disabled while updating otherwise the user could change any other else and we could run into race issues. Am I explaining myself?, is that clear?

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 832856 [details]
link to https://github.com/mozilla-b2g/gaia/pull/13740

Just found that I asked a wrong question in comment 12. I wanted to make sure that whether call forwarding and call waiting settings can be changed outside the panel. If no, we only need to refresh the item of caller ID when switching to settings app. Could you take a look at the patch again? Thanks!

Comment 17

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Arthur Chen [:arthurcc] from comment #16)

> Just found that I asked a wrong question in comment 12. I wanted to make
> sure that whether call forwarding and call waiting settings can be changed
> outside the panel. If no, we only need to refresh the item of caller ID when
> switching to settings app. Could you take a look at the patch again? Thanks!

We can change call waiting and call forwarding settings through MMI codes with the dialer app as well so If we want to add this improvement IMHO we should refresh the call waiting and call forwarding items, wdyt?

Comment 18

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 832856 [details]
link to https://github.com/mozilla-b2g/gaia/pull/13740

Patch updated.

Comment 19

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 832856 [details]
link to https://github.com/mozilla-b2g/gaia/pull/13740

Looks good to me! Once Travis goes green merge at will please. Thanks Arthur!

Comment 20

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks!

master: 60d39fb9ff02ac642399f0f36e174d90d9d9f79f

Comment 21

[Peter Dolanjski [:pdol]]

I'm not familiar enough with this to make a blocking call.  NI on Wilfred.

Comment 22

[Jason Smith [:jsmith]]

(In reply to Peter Dolanjski [:pdol] from comment #21)
> I'm not familiar enough with this to make a blocking call.  NI on Wilfred.

We really need to check with TEF here to find out if this could be a cert blocker.

Comment 23

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Jason Smith [:jsmith] from comment #22)
> (In reply to Peter Dolanjski [:pdol] from comment #21)
> > I'm not familiar enough with this to make a blocking call.  NI on Wilfred.
> 
> We really need to check with TEF here to find out if this could be a cert
> blocker.

ni? David Palomino.

Comment 24

[shawn ku [:sku]]

Hi all:

this is *not* a valid bug.
(agree with comment 14)

*31#/#31# is for single call only, and it should not take permanent effect.
For gaia setting, the "Caller ID" will apply for every outgoing calls.

And the priority is:
 temporary call ID > Caller ID in setting.


3GPP TS 22.030
Annex B
In temporary mode, to suppress CLIR for a single call, enter:
' * 31 # <called number> SEND '
In temporary mode, to invoke CLIR for a single call enter:
' # 31 # <called number> SEND '

Comment 25

[shawn ku [:sku]]

Sorry, please ignore comment 24.

I mess up with other thing.

Comment 26

[David Palomino [:dpalomino]]

> > We really need to check with TEF here to find out if this could be a cert
> > blocker.
> 
> ni? David Palomino.

Hi, 

IMHO it is not a blocker. It would be acceptable for carriers. 

Thks!
David

Comment 27

[Jason Smith [:jsmith]]

(In reply to David Palomino [:dpv] from comment #26)
> > > We really need to check with TEF here to find out if this could be a cert
> > > blocker.
> > 
> > ni? David Palomino.
> 
> Hi, 
> 
> IMHO it is not a blocker. It would be acceptable for carriers. 
> 
> Thks!
> David

Okay - good enough for me then to minus this off of that.

Comment 28

[KTucker [:KTucker][Inactive 3/4/2016]]

I wrote up this issue again because it is still occurring on the Buri v 1.3.0 Mozilla RIL 

Environmental Variables
Device: Buri v 1.3.0 Mozilla RIL
Build ID: 20131218004002
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/369bdbff6c38
Gaia: a99b23e73fe5630a877004746d0e7fcec1b6d653
Platform Version: 28.0a2

Here is the new issue:

https://bugzilla.mozilla.org/show_bug.cgi?id=951926

Comment 29

[José Antonio Olivera Ortega [:jaoo]]

(In reply to ktucker from comment #28)
> I wrote up this issue again because it is still occurring on the Buri v
> 1.3.0 Mozilla RIL 

The issue in this bug was about refreshing the call settings UI, there was no a bug in the CLIR settings at all.