AudioBufferSourceNode.stop(when) interprets when incorrectly when resampling

RESOLVED FIXED in mozilla28

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

25 Branch
mozilla28
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

"The when parameter describes at what time (in seconds) the sound should stop playing. It is in the same time coordinate system as AudioContext.currentTime."

Currently |when| is interpreted on a timeline that advances with AudioContext.currentTime until playback starts and then in buffer time coordinates.
These two testcases should play for 1 second, but play for 4 seconds.
Ah, I don't know why but I seem to remember that I once wrote a patch to fix this.  I thought that I had gotten reviews and landed it but now I can't even find a bug, which tells me that I must have forgotten to even file the bug. :(
Attachment #831381 - Flags: review?(ehsan)
Attachment #831382 - Flags: review?(ehsan)
Once bug 937057 is fixed, this will be easier to test.  Patches here are helpful in fixing bug 937057.  It may be easiest to add stop calls to the test for bug 938450.
Blocks: 938450
Flags: in-testsuite?
No longer blocks: 938450
Blocks: 937057
Attachment #831381 - Flags: review?(ehsan) → review+
Attachment #831382 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/27c02b405be0
https://hg.mozilla.org/mozilla-central/rev/2e2cdd1826e1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Depends on: 952756
Depends on: 967972
You need to log in before you can comment on or make changes to this bug.