937475 - AudioBufferSourceNode.stop(when) interprets when incorrectly when resampling

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Karl Tomlinson (:karlt)]

"The when parameter describes at what time (in seconds) the sound should stop playing. It is in the same time coordinate system as AudioContext.currentTime."

Currently |when| is interpreted on a timeline that advances with AudioContext.currentTime until playback starts and then in buffer time coordinates.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: buffer-source-stop-rate-1.html

These two testcases should play for 1 second, but play for 4 seconds.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: buffer-source-stop-rate-2.html

Comment 3

[(no longer active)]

Ah, I don't know why but I seem to remember that I once wrote a patch to fix this.  I thought that I had gotten reviews and landed it but now I can't even find a bug, which tells me that I must have forgotten to even file the bug. :(

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: change DURATION from end-offset to duration and compare buffer length using integer sample count

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: separate stream position from buffer position so that stop time can use stream position

Comment 6

[Karl Tomlinson (:karlt)]

Once bug 937057 is fixed, this will be easier to test.  Patches here are helpful in fixing bug 937057.  It may be easiest to add stop calls to the test for bug 938450.

Comment 7

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/27c02b405be0
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e2cdd1826e1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/27c02b405be0
https://hg.mozilla.org/mozilla-central/rev/2e2cdd1826e1

Comment 9

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8187818246ad

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8187818246ad