937536 - [e.me] Custom Collection is generated without an icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Comment 1

[Amir Nissim (:amirn)]

I'm not able to reproduce this. Can you give it another try please?

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Doesn't reproduce but I saw it with my own two eyes. Let's leave this here for now so we don't forget.

Comment 3

[Evyatar 'Tron' Amitay (everything.me)]

This seems to be a cache issue - problem rendering an icon where some of its apps are in the cache.

STR:
1. Tap the Searchfield
2. Search for "movies"
3. Go back to the home screen
4. Long tap on wallpaper
5. Select "Add Collection"
6. Select "Movies"

Result:
The Movies collection is rendered without an icon

Expected:
The Movies collection is rendered with an icon

Comment 4

[Amir Nissim (:amirn)]

Attachment: Redirect to PR

Was not easy to reproduce.
Only after creating some suggested Collection and some custom ones, I was able to get an empty icons response from the server.

Comment 5

[Evyatar 'Tron' Amitay (everything.me)]

Comment on attachment 8343062 [details] [review]
Redirect to PR

a few comments on GH, but it works well and the issue is resolved.

Comment 6

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 8343062 [details] [review]
Redirect to PR

Couldn't reproduce on master consistently. Still, it never happened with the patch.

Comment 7

[Amir Nissim (:amirn)]

landed: https://github.com/mozilla-b2g/gaia/commit/9484125