Modify test_sms_to_dialer.py to use SendSMS atom

RESOLVED FIXED

Status

P4
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: zcampbell, Assigned: viorela)

Tracking

unspecified
Other
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v1.2 affected)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Instead of using the ui to send the message, change the test to use the sendSMS atom.

So test case will be:
1. Send SMS to phone using atom
2. Wait for SMS
3. Load Messages app
4. Open messages thread
5. Tap header/Resume remainder of test case
(Assignee)

Updated

5 years ago
Assignee: nobody → viorela.ioia
(Assignee)

Comment 1

5 years ago
Created attachment 832926 [details] [review]
modified test

pointer to github PR: https://github.com/mozilla-b2g/gaia/pull/13743
Attachment #832926 - Flags: review?(zcampbell)
Attachment #832926 - Flags: review?(trifandreialin)
Attachment #832926 - Flags: review?(moz.teodosia)
Attachment #832926 - Flags: review?(florin.strugariu)
Attachment #832926 - Flags: review?(andrei.hutusoru)
Attachment #832926 - Flags: review?(florin.strugariu) → review+
Attachment #832926 - Flags: review?(trifandreialin) → review+
(Reporter)

Updated

5 years ago
Attachment #832926 - Flags: review?(zcampbell)
Attachment #832926 - Flags: review?(moz.teodosia)
Attachment #832926 - Flags: review?(andrei.hutusoru)
Attachment #832926 - Flags: review-
(Reporter)

Comment 2

5 years ago
Revised test case:

1. Send SMS to phone using atom
2. Load Messages app
3. Wait for SMS
4. Open messages thread
5. Tap header/Resume remainder of test case
(Assignee)

Comment 3

5 years ago
Created attachment 8335239 [details] [review]
updated PR acccording to test case changes

pointer to Github PR
Attachment #8335239 - Flags: review?(zcampbell)
Attachment #8335239 - Flags: review?(trifandreialin)
Attachment #8335239 - Flags: review?(florin.strugariu)
Attachment #8335239 - Flags: review?(andrei.hutusoru)
Comment on attachment 8335239 [details] [review]
updated PR acccording to test case changes

LGTM except for the nit
Attachment #8335239 - Flags: review?(florin.strugariu) → review-
(Assignee)

Comment 5

5 years ago
Created attachment 8335325 [details] [review]
updated PR

pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/13743
Attachment #832926 - Attachment is obsolete: true
Attachment #8335239 - Attachment is obsolete: true
Attachment #8335239 - Flags: review?(zcampbell)
Attachment #8335239 - Flags: review?(trifandreialin)
Attachment #8335239 - Flags: review?(andrei.hutusoru)
Attachment #8335325 - Flags: review?(zcampbell)
Attachment #8335325 - Flags: review?(trifandreialin)
Attachment #8335325 - Flags: review?(florin.strugariu)
Attachment #8335325 - Flags: review?(florin.strugariu) → review+

Updated

5 years ago
Attachment #8335325 - Flags: review+
(Reporter)

Comment 6

5 years ago
Comment on attachment 8335325 [details] [review]
updated PR

r- see PR comments.
Attachment #8335325 - Flags: review?(zcampbell) → review-
(Assignee)

Updated

5 years ago
Attachment #8335325 - Flags: review- → review?
(Reporter)

Comment 8

5 years ago
Comment on attachment 8335325 [details] [review]
updated PR

r+
Attachment #8335325 - Flags: review?(trifandreialin)
Attachment #8335325 - Flags: review?
Attachment #8335325 - Flags: review+
Is there a reason this should not be uplifted to v1.2? I think not, so I am setting the flag.
status-b2g-v1.2: --- → affected

Comment 10

5 years ago
Created attachment 8339118 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106

Pointer to Github pull-request

Comment 11

5 years ago
Comment on attachment 8339118 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106

v1.2
Attachment #8339118 - Flags: review?(trifandreialin)
Attachment #8339118 - Flags: review?(florin.strugariu)
Attachment #8339118 - Flags: review?(bob.silverberg)
Comment on attachment 8339118 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106

I am seeing intermittent failures. See the PR for details.
Attachment #8339118 - Flags: review?(bob.silverberg) → review-
Attachment #8339118 - Flags: review?(florin.strugariu) → review-
Comment on attachment 8339118 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106

Comment in the pr
Attachment #8339118 - Flags: review?(trifandreialin) → review+
Comment on attachment 8339118 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106

r+, but with one change. Please see my comments in the PR for a solution to the intermittents I was seeing.
Attachment #8339118 - Flags: review- → review+

Comment 15

5 years ago
Comment on attachment 8339118 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106

Updated according reviews!
Attachment #8339118 - Flags: review+ → review?(bob.silverberg)
Comment on attachment 8339118 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106

my r+ still stands
The pull was updated
Attachment #8339118 - Flags: review- → review?(florin.strugariu)
Comment on attachment 8339118 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106

Good to merge when the tree reopens.
Attachment #8339118 - Flags: review?(bob.silverberg) → review+
Attachment #8339118 - Flags: review?(florin.strugariu) → review+
You need to log in before you can comment on or make changes to this bug.