937605 - Firefox fails to build on PPC64: GCInternals.h:29:5: error: ‘ZoneSelector’ does not name a type

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gustavo Luiz Duarte]

Firefox fails to build on PPC64 with the following error message:

 1:39.88 In file included from /home/buildbot/buildbot/slave/runtests/build/js/src/vm/ForkJoin.h:12:0,
 1:39.88                  from /home/buildbot/buildbot/slave/runtests/build/js/src/builtin/TestingFunctions.cpp:22:
 1:39.88 /home/buildbot/buildbot/slave/runtests/build/js/src/gc/GCInternals.h:29:5: error: ‘ZoneSelector’ does not name a type


For the full build log, see: http://mozillaproject.osuosl.org:8010/builders/runtests/builds/517/steps/shell/logs/stdio

Comment 1

[Gustavo Luiz Duarte]

This seems to have been introduced by bug #928050

Comment 2

[Landry Breuil (:gaston)]

This also broke OpenBSD/sparc64 the same way, see http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/610/steps/build/logs/stdio

In file included from /home/buildslave/mozilla-central-sparc64/build/js/src/vm/ForkJoin.h:12:0,
                 from /home/buildslave/mozilla-central-sparc64/build/js/src/builtin/TestingFunctions.cpp:22:
/home/buildslave/mozilla-central-sparc64/build/js/src/gc/GCInternals.h:29:5: error: 'ZoneSelector' does not name a type
     ZoneSelector selector;
     ^
/home/buildslave/mozilla-central-sparc64/build/js/src/gc/GCInternals.h:32:45: error: 'ZoneSelector' has not been declared
     AutoCopyFreeListToArenas(JSRuntime *rt, ZoneSelector selector);
                                             ^
/home/buildslave/mozilla-central-sparc64/build/js/src/gc/GCInternals.h:68:42: error: 'ZoneSelector' has not been declared
     AutoPrepareForTracing(JSRuntime *rt, ZoneSelector selector);

Comment 3

[Gregor Wagner [:gwagner]]

Attachment: 937605.diff

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 833162 [details] [diff] [review]
937605.diff

Review of attachment 833162 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/GCInternals.h
@@ +8,5 @@
>  #define gc_GCInternals_h
>  
>  #include "jsworkers.h"
>  
> +#include "Zone.h"

Please use "gc/Zone.h" instead.

Comment 5

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/b2g-inbound/rev/3fd4dabd1d2c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3fd4dabd1d2c

Comment 7

[u279076]

Gustavo, can you please verify this is fixed in Firefox 28?

Comment 8

[Gustavo Luiz Duarte]

Yes, this is fixed. Thanks folks!

Comment 9

[u279076]

Thanks Gustavo.