937616 - Click-to-play notifications should track plugins that are no longer present in the page

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

Some sites, such as apparently Google Earth, try to create a plugin but when they fail they remove it from the document again. This prevents someone from whitelisting the plugin.

Comment 1

[[e-mail]]

Attachment: WIP

Comment 2

[[e-mail]]

Attachment: Just handle the Always Activate case

* Keeps track of plugin types used on a page
* Allow/Block applies to all types ever used on that page
* When remembering to allow, reload the page if some plugins no longer exist (always allow is the only way of accessing those plugins).

Note that when you use the last centre action the doorhanger is always removed even though there may be removed plugins to allow.

Comment 3

[Frank Wein [:mcsmurf]]

For reference: The corresponding Firefox bug is Bug 745187 (they solved the bug another way)

Comment 4

[Frank Wein [:mcsmurf]]

Comment on attachment 830833 [details] [diff] [review]
Just handle the Always Activate case

I see, we don't remember the plugin-has-been-activated decision on reload. Patch looks fine, works fine and all tests pass.

Comment 5

[Philip Chee]

Comment on attachment 830833 [details] [diff] [review]
Just handle the Always Activate case

f=me.

Comment 6

[[e-mail]]

Pushed comm-central changeset 00705b36d10c.

Comment 7

[[e-mail]]

Comment on attachment 830833 [details] [diff] [review]
Just handle the Always Activate case

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Lack of parity with Firefox 26
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky):
String changes made by this patch: None

Comment 8

[[e-mail]]

http://hg.mozilla.org/releases/comm-aurora/rev/70d35117ff59