Closed
Bug 937660
Opened 11 years ago
Closed 11 years ago
Move timezone settings from the setUp into testvars.json
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)
Tracking
(b2g-v1.2 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g-v1.2 | --- | fixed |
People
(Reporter: zcampbell, Unassigned)
Details
Attachments
(2 files)
Setting the timezone to Los Angeles/PST [0] is causing one of our partners testing problems because they don't operate in this timezone. We can remove the two lines that do the setting of time entirely. To restore the setting, we can move it into the webqa-credentials/b2g/*.json files. Then it gets set in the step marked "# restore settings from testvars". This makes the setting of timezone optional, thus making the setUp process more flexible for users of gaiatest but without affecting Mozilla's use either. I am not sure how this will affect desktopb2g tests so please run the time/date sensitive desktopb2g tests thoroughly. You will also need to email the gaia-ui-automation list to let users know of the change and to update their local testvars.json files. [0] https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#L510
Comment 1•11 years ago
|
||
Pointer to Github pull-request
Updated•11 years ago
|
Attachment #831482 -
Flags: review?(zcampbell)
Attachment #831482 -
Flags: review?(bob.silverberg)
Comment 2•11 years ago
|
||
I think that we should have a second PR attached to this bug that changes all the testvars files for our devices. Also, where are the testvars files that are used for Travis and TBPL. Those may need to be updated too. I am wondering if this is really such a good idea, or whether we should just advise anyone who doesn't want the default values from gaia_test to just add those settings to their own testvars file. They would then override our defaults, wouldn't they?
Reporter | ||
Comment 3•11 years ago
|
||
I initially said that we should update the webqa-credentials json files but then Bebe and I were talking and we're not 100% sure that we even need to force these settings anymore. Our first adhoc run bombed out but running again now to see. I'm not sure this setting isn't just an artifact of some old setUp from before we knew how to set up the device properly. http://qa-selenium.mv.mozilla.com:8080/job/b2g.hamachi.mozilla-central.ui.adhoc/41/console Anyway a partner did contact me to say it was causing them trouble as they operate in Europe rahter than California. For us to move where we set the timezone is not a great load of trouble and I'd like to help them. Ideally we discover we don't need to set it at all for our tests. Travis/TBPL don't use json files at all so no problem there.
Comment 4•11 years ago
|
||
I made the pull: https://github.com/mozilla/webqa-credentials/pull/98 If we decide it's not needed just close it
Comment 5•11 years ago
|
||
IIRC this was needed for the calendar tests because the device time differs from the host machine time. Desktop (and likely emulator) are not affected because they share the time from the host machine.
Reporter | ||
Comment 6•11 years ago
|
||
Comment on attachment 831482 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13657 r+
Attachment #831482 -
Flags: review?(zcampbell) → review+
Reporter | ||
Comment 7•11 years ago
|
||
I think so Dave. I'm quite happy to give it a go without the setUp steps. We can keep Bebe's credentials pull on hand. Bob I'll give you the final word to merge!
Updated•11 years ago
|
Attachment #831482 -
Flags: review?(bob.silverberg) → review+
Comment 8•11 years ago
|
||
Yes, I believe that's why we needed it. I guess we can see if it starts failing on device again. Landed in https://github.com/mozilla-b2g/gaia/commit/61e59d776649ab5b5b81fbb9223b3e6ecf471289 This should be ported to v1.2 too.
status-b2g-v1.2:
--- → affected
Comment 9•11 years ago
|
||
Pointer to Github pull-request
Comment 10•11 years ago
|
||
Comment on attachment 832246 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13702#attch-to-bugzilla Uplifted to v1.2
Attachment #832246 -
Flags: review?(trifandreialin)
Attachment #832246 -
Flags: review?(moz.teodosia)
Attachment #832246 -
Flags: review?(bob.silverberg)
Updated•11 years ago
|
Attachment #832246 -
Flags: review?(moz.teodosia) → review+
Comment 11•11 years ago
|
||
Landed in v1.2 https://github.com/mozilla-b2g/gaia/commit/da8996355ccd21855bdf0e908c9716071b3e2374
Updated•11 years ago
|
Attachment #832246 -
Flags: review?(trifandreialin)
Attachment #832246 -
Flags: review?(bob.silverberg)
Attachment #832246 -
Flags: review+
You need to log in
before you can comment on or make changes to this bug.
Description
•