Closed
Bug 937719
Opened 11 years ago
Closed 11 years ago
Add a pitch for careers in the source on the mozilla.org front page
Categories
(Websites :: Tabzilla, enhancement)
Websites
Tabzilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wenzel, Assigned: wenzel)
Details
Something I saw on the Interwebs: To entice people to apply for a job or participate as volunteers, we should add a pitch for the careers page to the Mozilla.org front page. I suggest the following: - put a message into the DOM (in a display:hidden node, maybe?) - push that same message to the console This way both "view source" and "open the console" people see it. If you give me a text, I am happy to file a pull request.
Assignee | ||
Comment 1•11 years ago
|
||
Mathew, what do you think, and do you want to give the phrasing a shot?
Flags: needinfo?(mcaldwell)
Comment 2•11 years ago
|
||
Since the mozilla.org homepage is now localized, should this hidden comment be localized or en-US only? Probably en-US is suffice given the careers and jobvite en-US experience.
Assignee | ||
Comment 3•11 years ago
|
||
If the text is in the DOM somewhere, it can easily be localized. Doesn't mean it has to, of course. If it originates from some JS code, then it's probably easiest to stick with English.
Comment 4•11 years ago
|
||
This might be a cool addition to Tabzilla actually. It's both JS and has localized strings, so it could do both (just for the console) and would show up on most mozilla sites. We could do the source comment as well, but it'd be nice to get it out there even wider. It's possible this is too intrusive a use of Tabzilla though. Thoughts?
Assignee | ||
Comment 5•11 years ago
|
||
Are tabzilla users decidedly internal to Mozilla? Then I think it'd work quite well. When using Tabzilla you're already pulling in centrally provided content at the top, I don't think the console logging would be intrusive. After all, only a small amount of users will see it. Besides, it's not all that different from adding "want to join Mozilla?" to the tabzilla content itself.
Comment 6•11 years ago
|
||
Agreed. I think tabzilla makes the most sense from a message distribution and l10n perspective. Let's do it :)
Updated•11 years ago
|
Severity: normal → enhancement
Component: Pages & Content → Tabzilla
Product: www.mozilla.org → Websites
Assignee | ||
Comment 7•11 years ago
|
||
I added a pull request for this: https://github.com/mozilla/bedrock/pull/1411 pmac, Mathew: r?
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → fwenzel
Comment 8•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/cebcf013aa8bf2a182056c0533863afb59fc141d Careers teaser in comment and error console. Bug 937719. https://github.com/mozilla/bedrock/commit/f3028a77e034cdc196f951e9e7eff5a2a9586eee Merge pull request #1411 from fwenzel/careers-teaser Careers teaser in comment and error console. Bug 937719.
Assignee | ||
Comment 9•11 years ago
|
||
Landed on master!
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(mcaldwell)
Resolution: --- → FIXED
Comment 10•11 years ago
|
||
fixed on dev
Comment 12•11 years ago
|
||
<meta charset> element must be *within the 512 first bytes* of the page. This teaser should go after <meta charset>. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta#attr-charset
Comment 13•11 years ago
|
||
(In reply to Edgaras from comment #12) > <meta charset> element must be *within the 512 first bytes* of the page. > > This teaser should go after <meta charset>. > > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta#attr-charset Thanks for the note! Wenzel: can you do another PR to over the charset up above the careers teaser?
Status: VERIFIED → RESOLVED
Closed: 11 years ago → 11 years ago
Flags: needinfo?(fwenzel)
Assignee | ||
Comment 14•11 years ago
|
||
We don't reopen verified bugs for a new issue normally, but yes I can.
Status: RESOLVED → REOPENED
Flags: needinfo?(fwenzel)
Resolution: FIXED → ---
Comment 15•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/875503f36ce558df58da7b0b54a39c355be761a5 Move charset declaration up in page, so it is within first 512 bytes. Bug 937719 comment 12. https://github.com/mozilla/bedrock/commit/7ef5a41f2bb56bc571173e6f6b1a45e8de11609e Merge pull request #1469 from fwenzel/meta-charset Bug 937719 comment 12: Move charset declaration up in page
Assignee | ||
Comment 16•11 years ago
|
||
Sad that the W3C validator did not appear to flag this, btw.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•