Closed Bug 937870 Opened 8 years ago Closed 8 years ago
Search Service displays duplicate engine prompt regardless of confirmation set by caller
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/search/nsSearchService.js#1475 The prompt for adding a duplicate engine should only be displayed if the caller sets confirm = true. Implementation also doesn't match comment.
Comment on attachment 831117 [details] [diff] [review] Patch: check confirmation for duplicate engine prompt The !engineToUpdate check needs to stay there, since we allow "duplicate" installs in that case (the comment should probably be updated too). Looks like http://hg.mozilla.org/mozilla-central/rev/e9b946da20cb (bug 493051) regressed this, there should be an additional _confirm check before calling promptError.
Attachment #831117 - Flags: review?(gavin.sharp) → review-
BTW, while you're fixing search stuff, maybe you're interested in fixing bug 863474? :) (I imagine it could be useful for Android since it'd let you do a custom prompt.)
Component: General → Search
Product: Toolkit → Firefox
(In reply to :Gavin Sharp (email email@example.com) from comment #2) > there should be an additional if (_confirm) check before > calling promptError. Oh, and in the !_confirm case, we need to call onError() instead.
Thanks for the suggestions! Updated the comments as well.
Comment on attachment 831155 [details] [diff] [review] Patch: check confirmation for duplicate engine prompt v2 Thanks a lot!
Attachment #831155 - Flags: review?(gavin.sharp) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.