Closed
Bug 937916
Opened 11 years ago
Closed 11 years ago
Implement TrueValue() and FalseValue()
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: sfink, Assigned: mz_mhs-ctb)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
731 bytes,
patch
|
Details | Diff | Splinter Review |
Seems to be missing, which looks wrong given UndefinedValue() and NullValue().
(Just filing while reading through bug 898359 and seeing JSVAL_FALSE.)
Attachment #831192 -
Flags: review?(sphink)
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 831192 [details] [diff] [review]
Patch
Review of attachment 831192 [details] [diff] [review]:
-----------------------------------------------------------------
That will do perfectly! Thanks for the instant patch!
Attachment #831192 -
Flags: review?(sphink) → review+
Attachment #831192 -
Attachment is obsolete: true
Eh, could you check this in for me? Don't have editbugs.
Flags: needinfo?(sphink)
|
||
Comment 5•11 years ago
|
||
(In reply to Michael [:Earth4] from comment #4)
> Don't have editbugs.
Now you do. :-) Use wisely.
Attachment #831278 -
Attachment description: Patch for checkin → Patch for checkin. r=sfink
Keywords: checkin-needed
|
||
Comment 7•11 years ago
|
||
I always get nervous when I see "Implement..." and no new tests being added. Should I be?
Assignee: nobody → mz_mhs-ctb
Flags: in-testsuite?
|
|
||
Comment 9•11 years ago
|
||
Given the simplicity of these methods, definitely not. :-)
|
|
||
Comment 10•11 years ago
|
||
Keywords: checkin-needed
|
||
Comment 11•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•