937916 - Implement TrueValue() and FalseValue()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

Seems to be missing, which looks wrong given UndefinedValue() and NullValue().

(Just filing while reading through bug 898359 and seeing JSVAL_FALSE.)

Comment 1

[Michael]

Attachment: Patch

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 831192 [details] [diff] [review]
Patch

Review of attachment 831192 [details] [diff] [review]:
-----------------------------------------------------------------

That will do perfectly! Thanks for the instant patch!

Comment 3

[Michael]

Attachment: Patch for checkin. r=sfink

Comment 4

[Michael]

Eh, could you check this in for me? Don't have editbugs.

Comment 5

[Jeff Walden [:Waldo]]

(In reply to Michael [:Earth4] from comment #4)
> Don't have editbugs.

Now you do.  :-)  Use wisely.

Comment 6

[Michael]

Thanks! :)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

I always get nervous when I see "Implement..." and no new tests being added. Should I be?

Comment 8

[Tom S [:evilpie]]

No.

Comment 9

[Jeff Walden [:Waldo]]

Given the simplicity of these methods, definitely not.  :-)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/33910284753c

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/33910284753c