Implement TrueValue() and FalseValue()

RESOLVED FIXED in mozilla28

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sfink, Assigned: mz_mhs-ctb)

Tracking

unspecified
mozilla28
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

Seems to be missing, which looks wrong given UndefinedValue() and NullValue().

(Just filing while reading through bug 898359 and seeing JSVAL_FALSE.)
Posted patch Patch (obsolete) — Splinter Review
Attachment #831192 - Flags: review?(sphink)
Comment on attachment 831192 [details] [diff] [review]
Patch

Review of attachment 831192 [details] [diff] [review]:
-----------------------------------------------------------------

That will do perfectly! Thanks for the instant patch!
Attachment #831192 - Flags: review?(sphink) → review+
Attachment #831192 - Attachment is obsolete: true
Eh, could you check this in for me? Don't have editbugs.
Flags: needinfo?(sphink)
(In reply to Michael [:Earth4] from comment #4)
> Don't have editbugs.

Now you do.  :-)  Use wisely.
Thanks! :)
Flags: needinfo?(sphink)
Attachment #831278 - Attachment description: Patch for checkin → Patch for checkin. r=sfink
Keywords: checkin-needed
I always get nervous when I see "Implement..." and no new tests being added. Should I be?
Assignee: nobody → mz_mhs-ctb
Flags: in-testsuite?
No.
Flags: in-testsuite? → in-testsuite-
Given the simplicity of these methods, definitely not.  :-)
https://hg.mozilla.org/mozilla-central/rev/33910284753c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.