Bug numbers should be removed from all Scratchpad test file names

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Developer Tools: Scratchpad
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: benvie, Assigned: lpy)

Tracking

Trunk
Firefox 28
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
We've stopped adding bug numbers to new test names, and would like to remove the bug numbers from existing test names. Example:

> browser/devtools/scratchpad/test/browser_scratchpad_bug684546_reset_undo.js

renamed to:

> browser/devtools/scratchpad/test/browser_scratchpad_reset_undo.js

A comment should also be added to the file indicating the bug number for reference so it can still be found if desired.

This will also involve updating browser.ini in the test directory to match the updated filenames.
(Assignee)

Updated

4 years ago
Assignee: nobody → pylaurent1314
(Assignee)

Comment 1

4 years ago
Created attachment 831450 [details] [diff] [review]
bug937953.patch
Attachment #831450 - Flags: review?(bbenvie)
(Reporter)

Comment 2

4 years ago
Comment on attachment 831450 [details] [diff] [review]
bug937953.patch

Review of attachment 831450 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #831450 - Flags: review?(bbenvie) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

4 years ago
Created attachment 832181 [details] [diff] [review]
bug937953.patch
Attachment #831450 - Attachment is obsolete: true
Attachment #832181 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/1340ee7d2e8d
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js] → [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1340ee7d2e8d
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js][fixed-in-fx-team] → [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.