Closed Bug 937953 Opened 9 years ago Closed 9 years ago

Bug numbers should be removed from all Scratchpad test file names

Categories

(DevTools Graveyard :: Scratchpad, defect)

Product:
DevTools Graveyard
Component:
Scratchpad
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 28

People

(Reporter: bbenvie, Assigned: lpy)

Details

(Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js])

Attachments

(1 file, 1 obsolete file)

bug937953.patch
18.56 KB, patch
lpy
: review+
Details | Diff | Splinter Review 
We've stopped adding bug numbers to new test names, and would like to remove the bug numbers from existing test names. Example:

> browser/devtools/scratchpad/test/browser_scratchpad_bug684546_reset_undo.js

renamed to:

> browser/devtools/scratchpad/test/browser_scratchpad_reset_undo.js

A comment should also be added to the file indicating the bug number for reference so it can still be found if desired.

This will also involve updating browser.ini in the test directory to match the updated filenames.
Assignee: nobody → pylaurent1314
Attached patch bug937953.patch (obsolete) — — Splinter Review 

        Attachment #831450 -
        Flags: review?(bbenvie)

    
    

    
  
Comment on attachment 831450 [details] [diff] [review]
bug937953.patch

Review of attachment 831450 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

        Attachment #831450 -
        Flags: review?(bbenvie) → review+

    
  
Keywords: checkin-needed

    
    

    
  

      
      
      
      

        Attached patch
          
          
        bug937953.patch
        — 
          — Splinter Review
      

    


  

        Attachment #831450 -
        Attachment is obsolete: true

        Attachment #832181 -
        Flags: review+

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/1340ee7d2e8d
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js] → [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js][fixed-in-fx-team]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1340ee7d2e8d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js][fixed-in-fx-team] → [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js]
Target Milestone: --- → Firefox 28

    
  
Product: Firefox → DevTools

    
  
Product: DevTools → DevTools Graveyard

          You need to log in
          before you can comment on or make changes to this bug.