938007 - Wrapper's footer close button is incorrectly screen-reader accessible.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

It looks like the close button's visibility is set to visible when the footer is closed and to hidden when the footer is opened.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi, I was wondering if there was a reason the close button was shown on closed footer.

Comment 2

[[e-mail]]

Yura, can you upload the screenshot, 
or have some description about the current / expect behavior of this issue?

Comment 3

[[e-mail]]

I just get what the issue means. Its a bug if close button shown in a closed footer

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi Fred, so the issue with the screen reader is that by default when homegesture.enabled is false, close button's visibility is set to visible (even though the footer is closed and not visible). This results in the close button being announced by the screen reader which is incorrect in case where it's not actually shown to the sighted user. As far as I understand, close button should only be visible when the wrapper footer is not closed and is visible, is that right?

So I guess, I was wondering if handling visibility of the close button specifically on homegesture.enabled change is necessary?

Comment 5

[[e-mail]]

Thanks for finding this, yes we still need to set the visibility to make sure the result is correct while developer switch the homegesture option, or the close button will always hidden after toggle the homegesture option.

But its more reasonable to put the close_button.style.visibility part into the 
footer.classList.contains('closed') part, thus the close button visibility is fully related to footer's state.

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Thanks, I will go ahead with the change then!

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Fred Lin [:gasolin] from comment #5)
> Thanks for finding this, yes we still need to set the visibility to make
> sure the result is correct while developer switch the homegesture option, or
> the close button will always hidden after toggle the homegesture option.
> 
Actually, I was wondering if the visibility of the close button is not set at all, it will be visible if the footer is not closed since we control the visibility of the whole footer?

Comment 8

[[e-mail]]

just take a try and have a patch for it :)

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Pull request for 938007

Comment 10

[[e-mail]]

Comment on attachment 832016 [details] [review]
Pull request for 938007

When home gesture is enabled, the close icon should always be hidden and the footbar will always open.

BTW, please ask review? to [e-mail] since he is the right module owner (reviewer)

Comment 11

[Yura Zenevich [:yzen] (please use "needinfo")]

Updated the pull request, preserving the functionality mentioned by Fred.

Comment 12

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/049a03da269e493e4afc9765ad5f06981145d05d