938035 - the definition of device orientation in firefox is not same as w3c spec

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[viral [:viralwang]]

What we currently do is to get the device orientation data from Android HAL and pass it to gaia. However, the orientation data we get from Android HAL didn't match the W3C spec.

In W3C spec, device orientation data contains alpha, beta, gamma
In Android HAL, it reports azimuth, pitch, and roll.

in Android HAL, azimuth=90 means East but alpha=90 means West in W3C spec
pitch and roll are similar to beta and gamma but with different sign.

One example:
(90, 30, -40) in Android HAL means the same orientation as (270, -30, 40) in W3C

For gonk backend, I would like to transform it in gecko/hal/gonk/GonkSensor.cpp
Also need to check the Android backend since we also found the difference in Android Firefox.

Comment 1

[Askeing Yen[:askeing][:fyen]]

ref link: http://www.w3.org/TR/orientation-event/

Comment 2

[viral [:viralwang]]

Attachment: Bug 938035 - the definition of device orientation in firefox is not same as w3c spec (v1)

Hi Dong,

This patch include the gonk and android backend to met the w3c spec for device orientation data.
Could you please help review this patch?
Thanks!

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 832837 [details] [diff] [review]
Bug 938035 - the definition of device orientation in firefox is not same as w3c spec (v1)

lgtm

Comment 4

[viral [:viralwang]]

Attachment: Bug 938035 - the definition of device orientation in firefox is not same as w3c spec (final)

add reviewer in comment.

Comment 5

[viral [:viralwang]]

Attachment: the definition of device orientation in firefox is not same as w3c spec (final)

Find a typo in comment :(

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/3d937509b0fe

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3d937509b0fe