Closed
Bug 938211
Opened 12 years ago
Closed 12 years ago
GenerationalGC: Heap<T> does not supply copy assignment operator
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: jonco, Assigned: jonco)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
4.12 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
There's no copy assignment operator defined for Heap<T>, so the compiler generates a default. The result is that assignment between Heap<T>s doesn't call postbarriers.
Here's a patch to add this. While I as at it, I added explicit copy assignment operators for TenuredHeap<T> and FakeRooted<T>, disallowed copy assignment of InternalHandle<T> and FakeMutableHandle<T>, and added an explicit copy constructor for InternalHandle<T>.
|
Assignee | |
Updated•12 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
|
|
Assignee | |
Updated•12 years ago
|
Attachment #831608 -
Flags: review?(sphink)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 831608 [details] [diff] [review]
fix-heap-assignment
Review of attachment 831608 [details] [diff] [review]:
-----------------------------------------------------------------
If it all still compiles, looks good to me!
Attachment #831608 -
Flags: review?(sphink) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•12 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•