93830 - Remove IsItAPrinter-hack from nsCSSFrameConstructor.cpp

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[Roland Mainz]

[Partially replacement for bug 92918:]
nsCSSFrameConstructor.cpp contains a hack using
|DeviceContextImpl->SupportsNativeWidgets()| to determinate whether the given
PresContext can be "scrolled" or uses a fixed media(=paper, not scrollable :-)
...

This code is simply wrong and should be replaced by the following code (from
latest patch in bug 92918):
-- snip --
diff -r -u original/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp
mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp
--- original/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp    Wed Jul
25 09:52:19 2001
+++ mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp     Thu Aug  2
19:26:39 2001
@@ -3764,22 +3764,15 @@
 
   // --------- IF SCROLLABLE WRAP IN SCROLLFRAME --------
 
-      // If the device supports scrolling (e.g., in galley mode on the screen
and
+  // If the device supports scrolling (e.g., in galley mode on the screen and
   // for print-preview, but not when printing), then create a scroll frame that
   // will act as the scrolling mechanism for the viewport. 
   // XXX Do we even need a viewport when printing to a printer?
-  // XXX It would be nice to have a better way to query for whether the device
-  // is scrollable
   PRBool  isScrollable = PR_TRUE;
   if (aPresContext) {
-    nsIDeviceContext* dc;
-    aPresContext->GetDeviceContext(&dc);
-    if (dc) {
-      PRBool  supportsWidgets;
-      if (NS_SUCCEEDED(dc->SupportsNativeWidgets(supportsWidgets))) {
-        isScrollable = supportsWidgets;
-      }
-      NS_RELEASE(dc);
+    PRBool  isPaginated = PR_FALSE;
+    if (NS_SUCCEEDED(aPresContext->IsPaginated(&isPaginated))) {
+      isScrollable = !isPaginated;
     }
   }
-- snip --

This code simply asks the |aPresContext| whether it is "paginated", e.g. if the
destination is a printer - or not.

Comment 1

[Roland Mainz]

Assigning to myself, setting milestone.

Comment 2

[Roland Mainz]

Attachment: patch for 2001-08-05-08-trunk

Comment 3

[Roland Mainz]

Filed patch.

Requesting r=/sr= ...

Comment 4

[timeless]

r=timeless

Comment 5

[Brendan Eich [:brendan]]

Roland, you know how to request super-review -- it's documented at
http://www.mozilla.org/hacking/reviewers.html.

/be

Comment 6

[Christopher Blizzard (:blizzard)]

Get an sr from waterson or dcone.

Comment 7

[Chris Waterson]

sr=waterson if dcone is okay with it.

Comment 8

[Roland Mainz]

dcone:
I need a r= from you, please :-)

Comment 9

[dcone (gone)]

If you want to know if you going to a printer, you can queryinterface to a 
printcontext.  If all you want to know is if your pagenated or not,  this is the 
correct way.  Assuming you just want to know if your pagenated.. r=dcone.

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Roland has requested I check this in.  Since it's r/sr'd, I'll do it when i do
bug 92641.

Comment 11

[Roland Mainz]

jesup:
Did you check this patch "in" yet ?

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

I'll check in shortly after making sure it compiles/runs in my machine

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

Patch applied