Closed Bug 938315 Opened 9 years ago Closed 9 years ago

Update nestegg to support Opus elements

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: rillian, Assigned: j)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

0001-Bug-938315-Update-nestegg-to-support-Opus-elements.patch
7.81 KB, patch
kinetik
: review+
Details | Diff | Splinter Review 
In addition to adding the codec type nestegg needs support for new elements and codecprivate parsing to handle Opus in WebM.
In particular we need to land https://github.com/kinetiknz/nestegg/pull/14
Depends on: 888789
codecprivate parsing will happen in firefox, eventually sharing code with the ogg backend.

work in progress at https://github.com/bit/mozilla-central/commits/opus

nestegg needs support for DiscardPadding, once working I can add to pull/14 or open new request.
https://github.com/kinetiknz/nestegg/pull/14 now contains support for DiscardPadding.
Blocks: 938686
Comment on attachment 8334448 [details] [diff] [review]
0001-Bug-938315-Update-nestegg-to-support-Opus-elements.patch

This updates the in-tree copy to upstream git.
Attachment #8334448 - Flags: review?(kinetik)
Attachment #8334448 - Flags: review?(kinetik) → review+
https://hg.mozilla.org/mozilla-central/rev/13da3402d682
Assignee: nobody → j
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.