938321 - [email/backend] Implement utf-7 charset support using hand-rolled decoder.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

Per thunderbird bug 677111 at least Outlook 11 in recent history has produced utf-7 encoded HTML body parts.  Our Buffer abstraction or decoding fake implementation should learn to decode utf-7.

Note that UTF-7 support was removed from the system in general because of XSS and detection issues for HTML.  I don't believe these are concerns for our e-mail use case given how we inject text/plain and (sanitized) text/html messages.

Comment 1

[Marcus Cavanaugh [:mcav]]

Attachment: gelam.html

I pulled the utf-7 encoder from https://github.com/kkaefer/utf7. I pulled it into its own file rather than pulling in the node module because it hasn't been updated since 2011 and it seemed like overkill, but I'd be happy to pull in a node-dep if you'd prefer that structure.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8345634 [details]
gelam.html

It is with a heavy heart that I allow you to inflict the ramblings of Outlook users upon our user-base... ;)

Thanks for the fix!

Comment 3

[Marcus Cavanaugh [:mcav]]

Landed in gaia: https://github.com/mozilla-b2g/gaia/commit/cfa88581f0bdaa3d4b7a3773ae87edc55260a2ab
and gelam: https://github.com/mozilla-b2g/gaia-email-libs-and-more/commit/dbf456e3f53776694fe75154314a504b0036fb0d

Comment 4

[Anthony Ricaud (:rik)]

This is breaking 6 marionnette-js tests so I had to back it out. https://github.com/mozilla-b2g/gaia/commit/7852023abb572c522a07af558e7c19f557cc4866

You can see the errors in https://travis-ci.org/mozilla-b2g/gaia/jobs/15424346

Comment 5

[Anthony Ricaud (:rik)]

Sorry, that was a bad backout from my part. I saw email tests starting to fail after a commit for email and didn't verify it was fixing the tree before applying the revert.

I re-landed the patch in https://github.com/mozilla-b2g/gaia/commit/59b8971.